Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MoonbeamFinalityApi to fully async/await #2784

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

fgamundi
Copy link
Contributor

What does it do?

Changes the asynchronous waiting mechanism from futures::block_on to await to wait for frontier_backend_client calls

librelois
librelois previously approved these changes Apr 25, 2024
@librelois librelois added B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes labels Apr 25, 2024
@librelois librelois merged commit 115bafc into moonbeam-foundation:master Apr 25, 2024
26 checks passed
@fgamundi fgamundi deleted the fg/finality-api-async branch April 25, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants