[FIXED] Memory growth from NRG create and delete operations #5600
+50
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Collison <derek@nats.io>
…egistering Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
This mostly stemmed from subscriptions being held in per connection caches (routers and gateways). These held references to both clients and any icb, which usually were closures so would also hold reference to the struct target as well. The code was not working correctly as it would only delete the subject in question, but when generation id changes we need to blow the whole cache similar to normal clients. Signed-off-by: Derek Collison <derek@nats.io>
wallyqs
pushed a commit
that referenced
this pull request
Jun 27, 2024
Fix for situations where GC struggled to clean up things. This mostly stemmed from subscriptions being held in per connection caches (routers and gateways). These held references to both clients and any internal callbacks, which usually were closures so would also hold reference to the struct target as well. Signed-off-by: Derek Collison <derek@nats.io> --------- Signed-off-by: Derek Collison <derek@nats.io>
wallyqs
added a commit
that referenced
this pull request
Jun 27, 2024
This was referenced Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for situations where GC struggled to clean up things.
This mostly stemmed from subscriptions being held in per connection caches (routers and gateways). These held references to both clients and any internal callbacks, which usually were closures so would also hold reference to the struct target as well.
Signed-off-by: Derek Collison derek@nats.io