Logstasher instrumentation #2559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahramadan
changed the title
if the log decorator is given a hash, merge the metadata into the hash
separate out the `return` logic and the `merge` logic to ensure that hashes always result in an early return
log decorator: support hashes
- Aggregator: check for LogStasher - Instrumentation: reurn data v log - Aggregator: don't alter original log
fallwith
reviewed
Jun 24, 2024
lib/new_relic/agent/instrumentation/logstasher/instrumentation.rb
Outdated
Show resolved
Hide resolved
lib/new_relic/agent/instrumentation/logstasher/instrumentation.rb
Outdated
Show resolved
Hide resolved
Co-authored-by: James Bunch <fallwith@gmail.com>
hannahramadan
commented
Jul 3, 2024
|
|
||
| if NewRelic::Agent.config[METRICS_ENABLED_KEY] |
There was a problem hiding this comment.
A few blocks of code were shared by create_event and create_logstasher_event. This is an example of a block of code moved into a new method (increment_event_counters is the name for this)
hannahramadan
commented
Jul 3, 2024
| return if severity_too_low?(severity) | ||
| return if formatted_message.nil? || formatted_message.empty? | ||
| return unless NewRelic::Agent.config[FORWARDING_ENABLED_KEY] | ||
| return if @high_security |
There was a problem hiding this comment.
This block of code lives in a new method, monitoring_conditions_met?
hannahramadan
changed the title
fallwith
reviewed
Jul 9, 2024
fallwith
reviewed
Jul 9, 2024
Co-authored-by: James Bunch <fallwith@gmail.com>
fallwith
approved these changes
Jul 9, 2024
SimpleCov Report
|
kaylareopelle
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for LogStasher gem versions 1.0.0 and above.
Full CI run: https://github.com/newrelic/newrelic-ruby-agent/actions/runs/9861763118
Test Coverage: 100% new code coverage
closes #2399