Lockdown Elasticsearch instrumentation to 7+ #2731
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahramadan
requested review from
fallwith,
kaylareopelle and
tannalynn
as code owners
SimpleCov Report
|
kaylareopelle
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ruby agent officially supports Elasticsearch versions 7+, but didn't prevent versions less than 7 from being instrumented because there were no known issues. With #2730, it looks like this may have changed when the agent changed the endpoint it reached out to for the cluster name (commit).
We typically only install instrumentation of supported library versions and Elasticsearch should be the same. This PR prevents instrumentation from installing on versions less than 7.