Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle http URLs gracefully #158

Open
aso1124 opened this issue Apr 18, 2023 · 1 comment
Open

Handle http URLs gracefully #158

aso1124 opened this issue Apr 18, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@aso1124
Copy link
Contributor

aso1124 commented Apr 18, 2023

Summary

URLs using http instead of https will be blocked by the browser due to a mixed content error. Statuses set up using an http URL will fail - currently, the UI will show a generic error that doesn't explain the source of the problem (it is only available by looking at the browser console).

Desired Behaviour

At a minimum, check for URLs using HTTP only, and block those URLs from being set up as a service.

When an HTTP URL is detected, the user should be presented with an informative message in the Add Service modal indicating the cause of the problem.

The user should be advised to test the URL with HTTPS - if it works, they can use the HTTPS URL; if it doesn't work, the URL can't be used in Status Pages.

@aso1124 aso1124 added the enhancement New feature or request label Apr 18, 2023
@shahramk
Copy link
Contributor

11-13-23

added TextFieldWrapper component to status-page.js so that I can use validationText property when a service is being edited
in main-page.js check the url for the service logo to ensure it uses secure url
3 hrs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants