Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow multiple source folders #2426

Merged
merged 1 commit into from
Apr 22, 2024
Merged

feat: Allow multiple source folders #2426

merged 1 commit into from
Apr 22, 2024

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Apr 8, 2024 •
edited
Loading

@artonge artonge added enhancement New feature or request php PHP related ticket javascript Javascript related ticket 2. developing Work in progress labels Apr 8, 2024
@artonge artonge added this to the Nextcloud 30 milestone Apr 8, 2024
@artonge artonge self-assigned this Apr 8, 2024
@artonge artonge force-pushed the artonge/feat/allow_mutliple_source_folders branch from e6394bd to bc77dc4 Compare April 9, 2024 12:08
This was referenced Apr 16, 2024
Merged
Closed
@artonge artonge force-pushed the artonge/feat/allow_mutliple_source_folders branch 4 times, most recently from d4387cf to ccabc26 Compare April 17, 2024 09:48
@artonge artonge requested review from skjnldsv and Pytal April 17, 2024 09:49
@artonge artonge added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 17, 2024
@artonge artonge force-pushed the artonge/feat/allow_mutliple_source_folders branch from ccabc26 to 9614d4b Compare April 17, 2024 11:34
@artonge artonge requested a review from susnux April 18, 2024 08:46
Pytal
Pytal approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature! Tested with server PR and code looks good

@artonge
feat: Allow multiple source folders
df19108 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/feat/allow_mutliple_source_folders branch from 9614d4b to df19108 Compare April 22, 2024 15:27
@artonge
Copy link
Collaborator Author

artonge commented Apr 22, 2024

/backport to stable29

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Apr 22, 2024
@artonge artonge enabled auto-merge April 22, 2024 15:30
@artonge artonge merged commit 2b28110 into master Apr 22, 2024
46 checks passed
@artonge artonge deleted the artonge/feat/allow_mutliple_source_folders branch April 22, 2024 16:41
@backportbot backportbot bot mentioned this pull request Apr 22, 2024
Merged
2 tasks
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Apr 22, 2024
@susnux
Copy link
Contributor

susnux commented Apr 22, 2024

BTW: Really nice feature 🚀

@Torqu3Wr3nch Torqu3Wr3nch mentioned this pull request Apr 26, 2024
Open
@joshtrichards joshtrichards mentioned this pull request Jun 18, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@susnux susnux Awaiting requested review from susnux

Assignees

@artonge artonge

Labels
3. to review Waiting for reviews enhancement New feature or request javascript Javascript related ticket php PHP related ticket
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

Add Support to additional folders by changing reworking "Choose another folder" to "Add folder"
3 participants
@artonge @susnux @Pytal