chore(deps): Update nextcloud/coding-standard and nextcloud/ocp #2510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
added
3. to review
artonge
force-pushed
the
artonge/deps/update_nc_packages
branch
6 times, most recently
from
46297d5
to
913dd91
Compare
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
artonge/deps/update_nc_packages
branch
from
913dd91
to
4d2299a
Compare
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
artonge/deps/update_nc_packages
branch
3 times, most recently
from
0c91e96
to
309fcb9
Compare
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
artonge/deps/update_nc_packages
branch
from
309fcb9
to
561d8d1
Compare
come-nc
approved these changes
Jul 2, 2024
| use OCP\Group\Events\GroupDeletedEvent; | ||
| use OCP\Group\Events\UserRemovedEvent; | ||
| use OCP\Share\Events\ShareDeletedEvent; | ||
| use OCP\User\Events\UserDeletedEvent; | ||
| use Psr\Log\LoggerInterface; | ||
|
|
||
| /** | ||
| * @template-implements IEventListener<Event|NodeDeletedEvent|GroupDeletedEvent|ShareDeletedEvent|UserDeletedEvent> |
There was a problem hiding this comment.
Suggested change
| * @template-implements IEventListener<Event|NodeDeletedEvent|GroupDeletedEvent|ShareDeletedEvent|UserDeletedEvent> | |
| * @template-implements IEventListener<NodeDeletedEvent|GroupDeletedEvent|ShareDeletedEvent|UserDeletedEvent> |
is Event really needed in there?
There was a problem hiding this comment.
No idea, it works with it, and does not hurt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2402
Fix #2508
Fix #2502
Fix #2499
Fix #2491
Fix #2487
Fix #2483
Fix #2471
Fix #2463
Fix #2454
Fix #2442
Fix #2429
Fix #2422
Fix #2416