Various fixes in preparation of 30 #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
artonge
commented
Jul 3, 2024
•
artonge
commented
| Change | Before | After |
|---|---|---|
| fix: Limit upload picker custom css to header |  |
 |
| dix: Populate photosLocationFolder on init |  |
 |
| fix: Make route name unique | Less warnings in browser console | |
| chore: Fix typo in collection.js | No more typo | |
| chore: Use NcSelect label | Less warnings in browser console and less custom code | |
| fix: Don't proceed with album creation if it fails | Prevents storing undefined in the albums store | |
| chore: Explicitly require @nc/router | Make linter happy | |
| fix: Specify a source for the tmp local album | Less warnings in browser console | |
| fix: Declare photosLocationFolder as computed | Fix uploading files from an album | |
| fix: Check if album is defined before accessing it in AlbumContent | Less errors in browser console | |
| chore: Remove useless v-if in AlbumContent | - | |
| fix: Reinit the files in File.vue | Fix rendering previews when adding a file to an album | |
| fix: Center empty content in empty albums | To make me happy | |
| feat: Display the upload button for empty albums | As it does not make sense to hide it in the first place |
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
artonge/fix/smoke_test_fixes
branch
from
ed7fb40
to
df8c363
Compare
artonge
added
bug
artonge
changed the title
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
added
3. to review
artonge
changed the title
This was referenced Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.