Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aliasing mimes #2099

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix aliasing mimes #2099

wants to merge 2 commits into from

Conversation

dan-r
Copy link

@dan-r dan-r commented Dec 16, 2023

A re-implementation of #1456 as that seems to have been abandoned. This issue mainly affects the use of ariariselseng/camerarawpreviews.

Fixes #1450 and ariselseng/camerarawpreviews#99.

I haven't noticed any regressions when testing this on my local environment and don't see any reason to not change the instantiation of this.currentFile to use this.components[mime] instead of handler.component. This is the approach already used for this.nextFile and this.previousFile.

This also fixes a regression in Viewer.js, allowing no mimes (only aliases) to be provided to registerHandler.

dan-r and others added 2 commits December 16, 2023 19:08
Signed-off-by: Daniel Raper <me@danr.uk>
Signed-off-by: Daniel Raper <me@danr.uk>
@kesselb
Copy link
Contributor

kesselb commented Dec 17, 2023

Are you sure that it does not break the overrideHandlerId feature?

@dan-r
Copy link
Author

dan-r commented Dec 21, 2023

@kesselb I'm not too familiar with that feature. It looks like it could break that, but in that case I'm not convinced it was working correctly to start with.

The assignments of nextFile and previousFile use this.components[mime] anyway so the initial file you click on would work with the overrideHandlerId function but if you go to the next file, it wouldn't work?

This comment was marked as resolved.

@skjnldsv skjnldsv added the 2. developing Work in progress label Mar 9, 2024
@DaphneMuller

This comment was marked as resolved.

@skjnldsv
Copy link
Member

@DaphneMuller this creates other issues, so it's staled until we have proper planning to resolve those issues.

@ariselseng
Copy link
Member

@skjnldsv My app camerarawpreviews has been broken due to this since at least Nextcloud 24. It would be great to get this merged/resolved soon. If you browse the issues at camerarawpreviews github repo there is a few duplicate issues every now and then about this.

@skjnldsv
Copy link
Member

skjnldsv commented Jun 4, 2024

@ariselseng merging this reverts another bug

I am stuck on this, and don't know what to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RAW photos are not displayed with infinite spinner
5 participants