fix(openIDConnect scheme): Check token expiration before id_token #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During an Axios call, the token is not automatically refreshed because it relies on the tokenExpired return of the scheme check function, which first checks id_token which often expires at the same time, and therefore does not detect any problems. By checking first the token expiration before the id_token, the problem is solved Related issue : nuxt-community#1370
|
Can you please add a summary of why this order is required as a comment in the code? Since we don't have tests, that's the only protection we have from making sure this doesn't break in future. And speaking of, unless we add tests, there will be risk of this changing in future without awareness of the repercussions. Finding a way to test this change -- in this PR or another one -- would go a long way to ensuring stability. See also #1393 |
|
Forgot to say -- thanks for the fix! |
Closed
|
@dygeenen - nice spot, I'm using a local copy of this version in my project. Looks like the linting failed in this PR though - keen to see this merged! |
|
dygeenen#1 |
|
@dygeenen : do you have some updates about this issue ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During an Axios call, the token is not automatically refreshed because it relies on the tokenExpired return of the scheme check function, which first checks id_token which often expires at the same time, and therefore does not detect any problems.
By checking first the token expiration before the id_token, the problem is solved
Related issue :
#1370