-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: collected during relation #759
base: master
Are you sure you want to change the base?
Conversation
'occurent' should be 'occurrent' (needs another 'r'). Perhaps be consistent in the use of 'material entity'? Information about 'specimen' could be in a one sentence gloss. E.g.:
|
This PR has not seen any activity in 90 days and has been marked as stale. If it is no longer needed, please close the PR. Otherwise, please update the PR with a status update. |
I made suggested change. This can now be approved and closed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically approved. It still needs ontology approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically approved. It still needs ontology approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Match label and definition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go!
@@ -44,6 +44,7 @@ Declaration(Class(obo:BFO_0000031)) | |||
Declaration(Class(obo:CHEBI_50906)) | |||
Declaration(Class(obo:COB_0001000)) | |||
Declaration(Class(obo:OGMS_0000031)) | |||
Declaration(Class(obo:PATO_0001470)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this PATO term was included in the edit file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird. I don't think that's from my end. I think that popped in as a result of refreshing this pull request against master?
A relation between a material entity and an occurent in which the specimen is collected during the existence of the occurent.