Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: collected during relation #759

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

WIP: collected during relation #759

wants to merge 9 commits into from

Conversation

ddooley
Copy link
Contributor

@ddooley ddooley commented Oct 9, 2023

A relation between a material entity and an occurent in which the specimen is collected during the existence of the occurent.

@ddooley ddooley changed the title collected during relation WIP: collected during relation Oct 9, 2023
@wdduncan
Copy link
Collaborator

'occurent' should be 'occurrent' (needs another 'r').

Perhaps be consistent in the use of 'material entity'? Information about 'specimen' could be in a one sentence gloss. E.g.:

A relation between a material entity and an occurrent in which the material entity is collected during the existence of the occurrent. The material entity is a specimen that collected for scientific purposes.

Copy link
Contributor

github-actions bot commented Jan 9, 2024

This PR has not seen any activity in 90 days and has been marked as stale. If it is no longer needed, please close the PR. Otherwise, please update the PR with a status update.

@github-actions github-actions bot added the stale label Jan 9, 2024
@ddooley
Copy link
Contributor Author

ddooley commented Jan 22, 2024

I made suggested change. This can now be approved and closed!

anitacaron
anitacaron previously approved these changes Jan 22, 2024
Copy link
Collaborator

@anitacaron anitacaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically approved. It still needs ontology approval.

anitacaron
anitacaron previously approved these changes Feb 9, 2024
Copy link
Collaborator

@anitacaron anitacaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically approved. It still needs ontology approval.

Copy link
Contributor

@cmungall cmungall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Match label and definition

src/ontology/ro-edit.owl Outdated Show resolved Hide resolved
Copy link
Contributor Author

@ddooley ddooley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@@ -44,6 +44,7 @@ Declaration(Class(obo:BFO_0000031))
Declaration(Class(obo:CHEBI_50906))
Declaration(Class(obo:COB_0001000))
Declaration(Class(obo:OGMS_0000031))
Declaration(Class(obo:PATO_0001470))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this PATO term was included in the edit file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird. I don't think that's from my end. I think that popped in as a result of refreshing this pull request against master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants