Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dbt ingestiont: Add Warning Log for Missing DBT Test Case Results in Manifest Nodes #16808

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TrsNium
Copy link
Contributor

@TrsNium TrsNium commented Jun 26, 2024

Describe your changes:

This PR adds a check to log a warning when DBT test case results are not found for a given manifest node.
The reason for the change is that the dbt_test_result object will be set to None depending on the result of dbt test, resulting in an error in subsequent processing.

[2024-06-26 08:21:27] ERROR    {metadata.Ingestion:metadata:960} - Failed to capture tests results for node: dbt_utils_not_accepted_values_layerone_dpf_card__if_mysql_layerone_card__moneytree_corporate_accounts_branch_code_________ 'NoneType' object has no attribute 'status'

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@ulixius9 ulixius9 added the safe to test Add this label to run secure Github workflows on PRs label Jun 26, 2024
Copy link

sonarcloud bot commented Jun 26, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants