awskinesis exporter records capacity is set too large #20914
Assignees
Comments
|
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
|
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
|
This issue has been closed as inactive because it has been stale for 120 days with no activity. |
dmitryax
pushed a commit
that referenced
this issue
Mar 25, 2024
Description: When a new Batch is created, it's slice capacity for the number of records should be set to the maximum number of records, not the max record size, an error that can cause memory to be allocated frequently. [awskinesisexporter/internal/batch/batch.go#L76-L82](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/41b5f81343828a37f709acf7788b08eb2c66730e/exporter/awskinesisexporter/internal/batch/batch.go#L76-L82) [awskinesisexporter/internal/batch/batch.go#L28-L29](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/41b5f81343828a37f709acf7788b08eb2c66730e/exporter/awskinesisexporter/internal/batch/batch.go#L28-L29) This is a copy of the original PR with the same fix found here: #20862 I've simply made the change to the tests that was requested in the original PR. Link to tracking Issue: Fixes #20914
rimitchell
pushed a commit
to rimitchell/opentelemetry-collector-contrib
that referenced
this issue
May 8, 2024
Description: When a new Batch is created, it's slice capacity for the number of records should be set to the maximum number of records, not the max record size, an error that can cause memory to be allocated frequently. [awskinesisexporter/internal/batch/batch.go#L76-L82](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/41b5f81343828a37f709acf7788b08eb2c66730e/exporter/awskinesisexporter/internal/batch/batch.go#L76-L82) [awskinesisexporter/internal/batch/batch.go#L28-L29](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/41b5f81343828a37f709acf7788b08eb2c66730e/exporter/awskinesisexporter/internal/batch/batch.go#L28-L29) This is a copy of the original PR with the same fix found here: open-telemetry#20862 I've simply made the change to the tests that was requested in the original PR. Link to tracking Issue: Fixes open-telemetry#20914
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component(s)
exporter/awskinesis
Describe the issue you're reporting
When a new Batch is created, it's slice capacity for the number of records should be set to the maximum number of records, not the max record size, an error that can cause memory to be allocated frequently.
awskinesisexporter/internal/batch/batch.go#L76-L82
awskinesisexporter/internal/batch/batch.go#L28-L29
The text was updated successfully, but these errors were encountered: