[receiver/statsd] Missing obsreport metrics from statsdreceiver

[sirianni]

Component(s)

receiver/statsd

What happened?

Description

The statsdreceiver does not properly expose obsreport metrics.

Steps to Reproduce

Send some OTLP and statsd metrics to a collector configured with both receivers.

Expected Result

I should see otelcol_receiver_accepted_metric_points_total timeseries for both receivers.

Actual Result

I see only a otelcol_receiver_accepted_metric_points_total timeseries for the otlp receiver.

$ curl http://localhost:8888/metrics | grep accepted_metric
# HELP otelcol_receiver_accepted_metric_points_total Number of metric points successfully pushed into the pipeline.
# TYPE otelcol_receiver_accepted_metric_points_total counter
otelcol_receiver_accepted_metric_points_total{receiver="otlp",transport="grpc"} 41

Collector version

v0.81.0

Environment information

Environment

Linux

OpenTelemetry Collector configuration

receivers:
  otlp:
    protocols:
      grpc:
  statsd:
exporters:
  logging:
    verbosity: detailed
service:
  telemetry:
    logs:
      level: DEBUG
      development: true
      encoding: console
  pipelines:
    metrics:
      receivers:
      - statsd
      - otlp
      processors: []
      exporters:
      - logging

Log output

2023-07-14T17:12:54.340-0400    info    MetricsExporter {"kind": "exporter", "data_type": "metrics", "name": "logging", "resource metrics": 1, "metrics": 1, "data points": 1}
2023-07-14T17:12:54.341-0400    info    ResourceMetrics #0
Resource SchemaURL: 
ScopeMetrics #0
ScopeMetrics SchemaURL: 
InstrumentationScope otelcol/statsdreceiver development
Metric #0
Descriptor:
     -> Name: synthetic.counter
     -> Description: 
     -> Unit: 
     -> DataType: Sum
     -> IsMonotonic: false
     -> AggregationTemporality: Delta
NumberDataPoints #0
Data point attributes:
     -> library: Str(statsd)
StartTimestamp: 2023-07-14 21:11:54.340264544 +0000 UTC
Timestamp: 2023-07-14 21:12:54.34085576 +0000 UTC
Value: 1
        {"kind": "exporter", "data_type": "metrics", "name": "logging"}

Additional context

The receiver does seem to be instrumented with obsreport

opentelemetry-collector-contrib/receiver/statsdreceiver/reporter.go

Line 92 in 5133f4c

r.obsrecv.EndMetricsOp(ctx, "statsd", numReceivedMessages, err)

so maybe there is a more subtle bug somewhere.

[github-actions]

Pinging code owners:

• receiver/statsd: @jmacd @dmitryax

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[sirianni]

Looks like the call to reporter.OnMetricsProcessed() was removed here

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• receiver/statsd: @jmacd @dmitryax

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• receiver/statsd: @jmacd @dmitryax

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been closed as inactive because it has been stale for 120 days with no activity.

[hardproblems]

I'd like to reopen this issue as we need some metrics for the receiver to monitor it in production (right now there is none)

[hardproblems]

/label receiver/statsd -Stale

[github-actions]

Pinging code owners for receiver/statsd: @jmacd @dmitryax. See Adding Labels via Comments if you do not have permissions to add labels yourself.

[sirianni]

I opened #31839 to address this. We are already using this code in production.

[dmitryax]

Resolved by #33415