azuremonitorexporter assign wrong parentId to span events

[Obi-Dann]

Component(s)

exporter/azuremonitor

What happened?

Description

azuremonitorexporter seems to assign wrong parentId to span events. As the results, span events have the same parentId as the span, but should have spanId as the parentId IIUC.

It looks like the issue is here
newEnvelope implementation should be different for span events, setting parentId to the spanId instead of always setting parentId to the span's parent id

Steps to Reproduce

Configure a collector with azuremonitor as an exported, set spaneventsenabled: true and ensure to send spans with events to the collector.

Expected Result

Span events should have the spanId set as their parentId

Actual Result

Span events have the span's parentId set as their parentId

Collector version

0.85.0

Environment information

Environment

OS: macOS 13.6

OpenTelemetry Collector configuration

receivers:
  otlp:
    protocols:
      http:

exporters:
  logging:
  azuremonitor:
    instrumentation_key: ""
    spaneventsenabled: true

processors:
  batch:
    timeout: 10s
    send_batch_size: 1000

service:
  pipelines:
    traces:
      receivers: [otlp]
      processors: []
      exporters: [logging, azuremonitor]
    logs:
      receivers: [otlp]
      processors: []
      exporters: [logging, azuremonitor]

Log output

No response

Additional context

No response

[github-actions]

Pinging code owners:

• exporter/azuremonitor: @pcwiese

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• exporter/azuremonitor: @pcwiese
• needs: Github issue template generation code needs this to generate the corresponding labels.

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[crobert-1]

The semantic conventions are a bit unclear here as there's no default attribute in a span event for parentID. I think your interpretation is fair in that it makes sense for the events of a span to be considered the children of the span itself. Wording it another way, the span can be considered a parent of all of its own events.

@pcwiese may have different thoughts as code owner though, and this may also break some people's existing assumptions and queries in the backend.

Relevant documentation: Semantic conventions

[alaendle]

We also encountered this issue while forwarding Zipkin events to Azure Monitor.
The current implementation just creates wrong impressions - the traces are one level-up in the tree; so one could expect that the trace was generated by the producer - even if the consumer produces the trace.
See the following AppInsights screenshot (I've added the red circles/arrows to illustrate the problem):

Please let me know if I could provide further information.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• exporter/azuremonitor: @pcwiese

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[alaendle]

This is solved as soon as #30659 is merged - so if anyone with rights to merge this PR reads this, please make progress at this point 📯 .

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• exporter/azuremonitor: @pcwiese

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[crobert-1]

Resolved by #30659