Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove spanmetricsprocessor #29567

Closed
atoulme opened this issue Nov 29, 2023 · 8 comments · Fixed by #31508
Closed

Remove spanmetricsprocessor #29567

atoulme opened this issue Nov 29, 2023 · 8 comments · Fixed by #31508
Labels
processor/spanmetrics Span Metrics processor

Comments

@atoulme
Copy link
Contributor

atoulme commented Nov 29, 2023

Component(s)

processor/spanmetrics

Describe the issue you're reporting

The spanmetrics processor has been deprecated since March 17, 2023 with #19751.

This issue tracks its eventual removal from the repository.
@atoulme atoulme added needs triage New item requiring triage processor/spanmetrics Span Metrics processor and removed needs triage New item requiring triage labels Nov 29, 2023
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for processor/spanmetrics: @albertteoh. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@atoulme
Copy link
Contributor Author

atoulme commented Nov 29, 2023

This was discussed in the SIG meeting of 11/29.

@crobert-1
Copy link
Member

crobert-1 commented Nov 29, 2023 •
edited
Loading

To add context, there's no given requirement around how long the component will still be in future releases, the minimum requirement is at least two minor releases. The definition of Deprecated is that it's planed to be removed in a future version, so it makes sense that we'll remove it at some point.

The main concern is communicating to users this plan so they move to the connector instead. As stated in description, it has been deprecated for a while, so we may just have to state a specific date or release that it will be removed in as motivation for users to make the move. Just a suggestion though, others may have more effective ideas.

@github-actions github-actions bot mentioned this issue Dec 5, 2023
Closed
@github-actions GitHub Actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jan 29, 2024
@crobert-1 crobert-1 removed the Stale label Jan 29, 2024
@mx-psi
Copy link
Member

mx-psi commented Feb 6, 2024

I propose we remove this on the first release on March, which gives roughly one year of deprecation period. Would that be okay with everyone @open-telemetry/collector-contrib-approvers ?

@atoulme
Copy link
Contributor Author

atoulme commented Feb 6, 2024

I think this processor is now unmaintained as well, fwiw.

This was referenced Feb 29, 2024
Merged
Merged
Merged
@mx-psi
Copy link
Member

mx-psi commented Feb 29, 2024

I filed the following PRs for this:

djaglowski pushed a commit that referenced this issue Feb 29, 2024
@mx-psi
Remove spanmetrics processor (#31508)
b01fd36 
**Description:** 

Remove deprecated spanmetrics processor.

**Link to tracking Issue:** Fixes #29567
mx-psi added a commit to open-telemetry/opentelemetry-collector that referenced this issue Feb 29, 2024
@mx-psi
[chore] Remove or update mentions to spanmetrics processor (#9665)
c6c4c16 
**Description:** 

Updates mentions to `spanmetrics` processor and references `spanmetrics`
connector instead if applicable.

**Link to tracking Issue:** Relates to
open-telemetry/opentelemetry-collector-contrib#29567
kkujawa-sumo added a commit to SumoLogic/sumologic-otel-collector that referenced this issue Mar 6, 2024
@kkujawa-sumo
chore: update otelcol core to v0.96.0
0218a4d 
changes which impacts update:
- httpforwarder: Remove extension named httpforwarder, use httpforwarderextension instead
  ref: open-telemetry/opentelemetry-collector-contrib#24171
- spanmetricsprocessor: Remove spanmetrics processor
  ref: open-telemetry/opentelemetry-collector-contrib#29567
- confighttp: Remove deprecated HTTPClientSettings, NewDefaultHTTPClientSettings, and CORSSettings.
  ref: open-telemetry/opentelemetry-collector#9625
@kkujawa-sumo kkujawa-sumo mentioned this issue Mar 6, 2024
Merged
kkujawa-sumo added a commit to SumoLogic/sumologic-otel-collector that referenced this issue Mar 6, 2024
@kkujawa-sumo
chore: update otelcol core to v0.96.0
e8ac005 
changes which impacts update:
- httpforwarder: Remove extension named httpforwarder, use httpforwarderextension instead
  ref: open-telemetry/opentelemetry-collector-contrib#24171
- spanmetricsprocessor: Remove spanmetrics processor
  ref: open-telemetry/opentelemetry-collector-contrib#29567
- confighttp: Remove deprecated HTTPClientSettings, NewDefaultHTTPClientSettings, and CORSSettings.
  ref: open-telemetry/opentelemetry-collector#9625
kkujawa-sumo added a commit to SumoLogic/sumologic-otel-collector that referenced this issue Mar 6, 2024
@kkujawa-sumo
chore: update otelcol core to v0.96.0
e9e81ae 
changes which impacts update:
- httpforwarder: Remove extension named httpforwarder, use httpforwarderextension instead
  ref: open-telemetry/opentelemetry-collector-contrib#24171
- spanmetricsprocessor: Remove spanmetrics processor
  ref: open-telemetry/opentelemetry-collector-contrib#29567
- confighttp: Remove deprecated HTTPClientSettings, NewDefaultHTTPClientSettings, and CORSSettings.
  ref: open-telemetry/opentelemetry-collector#9625
kkujawa-sumo added a commit to SumoLogic/sumologic-otel-collector that referenced this issue Mar 7, 2024
@kkujawa-sumo
chore: update otelcol core to v0.96.0
5456880 
changes which impacts update:
- httpforwarder: Remove extension named httpforwarder, use httpforwarderextension instead
  ref: open-telemetry/opentelemetry-collector-contrib#24171
- spanmetricsprocessor: Remove spanmetrics processor
  ref: open-telemetry/opentelemetry-collector-contrib#29567
- confighttp: Remove deprecated HTTPClientSettings, NewDefaultHTTPClientSettings, and CORSSettings.
  ref: open-telemetry/opentelemetry-collector#9625
kkujawa-sumo added a commit to SumoLogic/sumologic-otel-collector that referenced this issue Mar 7, 2024
@kkujawa-sumo
chore: update otelcol core to v0.96.0
3c397ac 
changes which impacts update:
- httpforwarder: Remove extension named httpforwarder, use httpforwarderextension instead
  ref: open-telemetry/opentelemetry-collector-contrib#24171
- spanmetricsprocessor: Remove spanmetrics processor
  ref: open-telemetry/opentelemetry-collector-contrib#29567
- confighttp: Remove deprecated HTTPClientSettings, NewDefaultHTTPClientSettings, and CORSSettings.
  ref: open-telemetry/opentelemetry-collector#9625
- ConfigProvider is deprecated, use ConfigProviderSettings instead
  ref: open-telemetry/opentelemetry-collector#9228
kkujawa-sumo added a commit to SumoLogic/sumologic-otel-collector that referenced this issue Mar 7, 2024
@kkujawa-sumo
chore: update otelcol core to v0.96.0
a4f09fa 
changes which impacts update:
- httpforwarder: Remove extension named httpforwarder, use httpforwarderextension instead
  ref: open-telemetry/opentelemetry-collector-contrib#24171
- spanmetricsprocessor: Remove spanmetrics processor
  ref: open-telemetry/opentelemetry-collector-contrib#29567
- confighttp: Remove deprecated HTTPClientSettings, NewDefaultHTTPClientSettings, and CORSSettings.
  ref: open-telemetry/opentelemetry-collector#9625
- ConfigProvider is deprecated, use ConfigProviderSettings instead
  ref: open-telemetry/opentelemetry-collector#9228
XinRanZhAWS pushed a commit to XinRanZhAWS/opentelemetry-collector-contrib that referenced this issue Mar 13, 2024
@mx-psi @XinRanZhAWS
Remove spanmetrics processor (open-telemetry#31508)
ca19eaa 
**Description:** 

Remove deprecated spanmetrics processor.

**Link to tracking Issue:** Fixes open-telemetry#29567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
processor/spanmetrics Span Metrics processor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove spanmetrics processor mx-psi/opentelemetry-collector-contrib
3 participants
@atoulme @mx-psi @crobert-1