Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/datasetexporter]: Unused resources are not released #31292

Closed
martin-majlis-s1 opened this issue Feb 16, 2024 · 3 comments · Fixed by #31293
Closed

[exporter/datasetexporter]: Unused resources are not released #31292

martin-majlis-s1 opened this issue Feb 16, 2024 · 3 comments · Fixed by #31293
Labels
bug Something isn't working exporter/dataset

Comments

@martin-majlis-s1
Copy link
Contributor

Component(s)

exporter/dataset

What happened?

Description

If you are using datasetexporter for longer time period, it's memory consumption is only increasing. It should be more stable.

Steps to Reproduce

Run otel demo for some time period.

Expected Result

Memory usage should remain stable.

Actual Result

Memory usage is increasing.

Collector version

v0.94.0

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response
@martin-majlis-s1 martin-majlis-s1 added bug Something isn't working needs triage New item requiring triage labels Feb 16, 2024
@martin-majlis-s1 martin-majlis-s1 mentioned this issue Feb 16, 2024
Merged
@martin-majlis-s1
Copy link
Contributor Author

/label exporter/dataset

@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for exporter/dataset: @atoulme @martin-majlis-s1 @zdaratom-s1 @tomaz-s1. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@martin-majlis-s1
Copy link
Contributor Author

/label -needs-triage

@github-actions github-actions bot removed the needs triage New item requiring triage label Feb 16, 2024
jpkrohling pushed a commit that referenced this issue Feb 19, 2024
@martin-majlis-s1
[exporter/datasetexporter]: Release unused resources after some time (#…
d7f087f 
…31293)

**Description:** Release unused resources after some time

This PR is:
* upgrading the used library from v0.17.0 to v0.18.0
* introducing new configuration option - `buffer.purge_older_than`

**Link to tracking Issue:** #31292

**Testing:** 

Issue has been in the underlying library -
scalyr/dataset-go#75 - where I have fixed the
issue.

![Screenshot 2024-02-16 at 12 01
40](https://github.com/open-telemetry/opentelemetry-collector-contrib/assets/122797378/f1c80807-69de-49c4-aa62-7edd211e3b34)


**Documentation:** I have added documentation to the newly added
configuration option - `buffer.purge_older_than`.

Fixes #31292
djaglowski pushed a commit to djaglowski/opentelemetry-collector-contrib that referenced this issue Feb 19, 2024
@martin-majlis-s1 @djaglowski
[exporter/datasetexporter]: Release unused resources after some time (o…
22d7b64 
…pen-telemetry#31293)

**Description:** Release unused resources after some time

This PR is:
* upgrading the used library from v0.17.0 to v0.18.0
* introducing new configuration option - `buffer.purge_older_than`

**Link to tracking Issue:** open-telemetry#31292

**Testing:** 

Issue has been in the underlying library -
scalyr/dataset-go#75 - where I have fixed the
issue.

![Screenshot 2024-02-16 at 12 01
40](https://github.com/open-telemetry/opentelemetry-collector-contrib/assets/122797378/f1c80807-69de-49c4-aa62-7edd211e3b34)


**Documentation:** I have added documentation to the newly added
configuration option - `buffer.purge_older_than`.

Fixes open-telemetry#31292
djaglowski pushed a commit to djaglowski/opentelemetry-collector-contrib that referenced this issue Feb 19, 2024
@martin-majlis-s1 @djaglowski
[exporter/datasetexporter]: Release unused resources after some time (o…
21bd0de 
…pen-telemetry#31293)

**Description:** Release unused resources after some time

This PR is:
* upgrading the used library from v0.17.0 to v0.18.0
* introducing new configuration option - `buffer.purge_older_than`

**Link to tracking Issue:** open-telemetry#31292

**Testing:** 

Issue has been in the underlying library -
scalyr/dataset-go#75 - where I have fixed the
issue.

![Screenshot 2024-02-16 at 12 01
40](https://github.com/open-telemetry/opentelemetry-collector-contrib/assets/122797378/f1c80807-69de-49c4-aa62-7edd211e3b34)


**Documentation:** I have added documentation to the newly added
configuration option - `buffer.purge_older_than`.

Fixes open-telemetry#31292
This was referenced Feb 20, 2024
Closed
Open
XinRanZhAWS pushed a commit to XinRanZhAWS/opentelemetry-collector-contrib that referenced this issue Mar 13, 2024
@martin-majlis-s1 @XinRanZhAWS
[exporter/datasetexporter]: Release unused resources after some time (o…
1dec6fb 
…pen-telemetry#31293)

**Description:** Release unused resources after some time

This PR is:
* upgrading the used library from v0.17.0 to v0.18.0
* introducing new configuration option - `buffer.purge_older_than`

**Link to tracking Issue:** open-telemetry#31292

**Testing:** 

Issue has been in the underlying library -
scalyr/dataset-go#75 - where I have fixed the
issue.

![Screenshot 2024-02-16 at 12 01
40](https://github.com/open-telemetry/opentelemetry-collector-contrib/assets/122797378/f1c80807-69de-49c4-aa62-7edd211e3b34)


**Documentation:** I have added documentation to the newly added
configuration option - `buffer.purge_older_than`.

Fixes open-telemetry#31292
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working exporter/dataset
Projects
None yet
Milestone
No milestone
1 participant
@martin-majlis-s1