Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use confighttp for target allocator http client #31449

Closed
swiatekm opened this issue Feb 27, 2024 · 6 comments
Closed

Use confighttp for target allocator http client #31449

swiatekm opened this issue Feb 27, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request receiver/prometheus Prometheus receiver

Comments

@swiatekm
Copy link
Contributor

Component(s)

receiver/prometheus

Is your feature request related to a problem? Please describe.

We'd like to use TLS client authentication for communication between the collector and target allocator. A detailed discussion about the reasons can be found here: open-telemetry/opentelemetry-operator#1669.

Describe the solution you'd like

We should use go.opentelemetry.io/collector/config/confighttp. This is a standard for collector components and users should be comfortable with it. It will also give us a lot more customization for very little additional maintenance burden.

Describe alternatives you've considered

We could implement just the TLS options ourselves, but there doesn't seem to be any upside to that.

Additional context

No response

@swiatekm swiatekm added enhancement New feature or request needs triage New item requiring triage labels Feb 27, 2024
@github-actions github-actions bot added the receiver/prometheus Prometheus receiver label Feb 27, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@swiatekm
Copy link
Contributor Author

swiatekm commented Feb 27, 2024

If this sounds reasonable, you can assign this issue to me. I basically already have this change implemented, it's very small.

@dashpole
Copy link
Contributor

This seems reasonable to me. Is it breaking, or additive?

@swiatekm
Copy link
Contributor Author

Additive, the only common field is Endpoint, and the yaml key is the same. So it should be transparent to the user.

@dashpole
Copy link
Contributor

Sounds great. Feel free to open the PR.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Feb 28, 2024
TylerHelmuth pushed a commit that referenced this issue Mar 14, 2024
)

**Description:** 
Use confighttp for target allocator http client in prometheus receiver.

**Link to tracking Issue:**
#31449

**Testing:**
Added some simple config tests.

**Documentation:**
Added a note to the README.
@atoulme
Copy link
Contributor

atoulme commented Mar 26, 2024

#31452 is merged, can we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request receiver/prometheus Prometheus receiver
Projects
None yet
Development

No branches or pull requests

5 participants