Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update virtual node defaults and change feature gate to beta #31734

Closed
ogxd opened this issue Mar 13, 2024 · 2 comments
Closed

Update virtual node defaults and change feature gate to beta #31734

ogxd opened this issue Mar 13, 2024 · 2 comments

Comments

@ogxd
Copy link
Contributor

ogxd commented Mar 13, 2024

Component(s)

connector/servicegraph

Context

Started with this discussion: grafana/tempo#3480 (reply in thread)
@joe-elliott

The servicegraph connector has a feature for creating virtual nodes. There are currently three issues:

  • Some default values are now obsolete given semver (1.24).
    • net.peer.name (replaced by server.address on client spans and client.address on server spans)
    • net.sock.peer.name (removed)
    • net.sock.peer.addr (replaced by network.peer.address)
    • http.url (replaced by url.full)
    • http.target (split to url.path and url.query)
  • The feature is behind an "alpha" feature gate, which prevents it from being used (eg using otelcol helm chart). Plus there is no mention of it being disabled by default in the documentation.
  • Documentation is a little ambiguous

Proposition

  • Change default values to peer.service, db.name and db.system (in this order). These are compliant with conventions, and the same as the tempo service graph uses.
  • Switch the feature from "alpha" to "beta". Virtual nodes are working well on the tempo side, and feature could be disabled anyway by using an empty list if needed.
  • Reword documentation for improved clarity

See PR: #31735

@ogxd ogxd added the needs triage New item requiring triage label Mar 13, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@ogxd
Copy link
Contributor Author

ogxd commented Mar 28, 2024

Hello @Frapschen, the PR has been reviewed, but it is waiting for approval from another maintainer which seems like he isn't receiving notifications or is busy (he is active on other issues). Would it be possible to get a approval/final review (if necessary) on this PR?

Thanks a lot 😄

dmitryax pushed a commit that referenced this issue Apr 14, 2024
…ure gate to beta (#31735)

**Description:**

- Change default values to peer.service, db.name and db.system (in this
order). These are compliant with conventions, and the same as the tempo
service graph uses.
- Switch the feature from "alpha" to "beta". Virtual nodes are working
well on the tempo side, and feature could be disabled anyway by using an
empty list if needed.
- Reword documentation for improved clarity
- Fix "processor" that should be "connector" instead since recent commit

**Link to tracking Issue:**
#31734

**Testing:** No functional change requiring additional tests

**Documentation:** Updated documentation
@ogxd ogxd closed this as completed Apr 15, 2024
rimitchell pushed a commit to rimitchell/opentelemetry-collector-contrib that referenced this issue May 8, 2024
…ure gate to beta (open-telemetry#31735)

**Description:**

- Change default values to peer.service, db.name and db.system (in this
order). These are compliant with conventions, and the same as the tempo
service graph uses.
- Switch the feature from "alpha" to "beta". Virtual nodes are working
well on the tempo side, and feature could be disabled anyway by using an
empty list if needed.
- Reword documentation for improved clarity
- Fix "processor" that should be "connector" instead since recent commit

**Link to tracking Issue:**
open-telemetry#31734

**Testing:** No functional change requiring additional tests

**Documentation:** Updated documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants