[exporter/awss3] When using encoding extension, file format extension should be configurable #31818
Comments
|
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
|
Removing Thanks for filing and making the change @adcharre! |
crobert-1
added
enhancement
…ding (#31833) **Description:** Modify the behaviour of the exporter when using an encoding extension to add a user defined file extension or no extension at all if not configured. **Link to tracking Issue:** #31818 **Testing:** Unit tests **Documentation:** Added details of new configuration option.
…ding (open-telemetry#31833) **Description:** Modify the behaviour of the exporter when using an encoding extension to add a user defined file extension or no extension at all if not configured. **Link to tracking Issue:** open-telemetry#31818 **Testing:** Unit tests **Documentation:** Added details of new configuration option.
|
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
|
Can this issue be closed? It looks like it's been resolved by #31833. |
Closing, as indeed fixed by that PR. |
Component(s)
exporter/awss3
Describe the issue you're reporting
When using the new encoding extension option to marshal data introduced in PR #31801, the generated key contains the ID of the extension. This can be long and contain characters that either don't make sense for a file extension or could be invalid for an S3 key.
For example given an extension defined in the config file as:
A key would be generated similar to the following:
mytrace/year=2024/month=03/day=18/hour=12/minute=02/myprefixtrace_12345.textencoding/myspecialtextencoding(where
keyprefix=mytrace,prefix=myprefixandmetadata=trace)A better approach would be to allow the user to specify the required extension as part of the AWS S3 configuration or to have no extension at all.
The text was updated successfully, but these errors were encountered: