Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/dataset] Integration stress tests failing #32533

Closed
crobert-1 opened this issue Apr 18, 2024 · 2 comments · Fixed by #33675
Closed

[exporter/dataset] Integration stress tests failing #32533

crobert-1 opened this issue Apr 18, 2024 · 2 comments · Fixed by #33675
Labels
exporter/dataset Stale

Comments

@crobert-1
Copy link
Member

Component(s)

exporter/dataset

Describe the issue you're reporting

Failing CI/CD link

Note that this test hasn't been running for some time, as explained in #32207, so this failure may not be the result of a recent change.

Failure output:

Running target 'mod-integration-test' in module 'exporter/datasetexporter' as part of group 'exporter-0'
make --no-print-directory -C exporter/datasetexporter mod-integration-test
running go integration test ./... in /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/datasetexporter
/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/.tools/gotestsum --rerun-fails=1 --packages="./..." -- -race -timeout 360s -parallel 4 -tags=integration,""
∅  internal/metadata
✖  . (4.03s)

DONE 83 tests, 1 failure in 5.781s

✖  . (2.017s)

=== Failed
=== FAIL: . TestConsumeLogsManyLogsShouldSucceed (2.00s)
    logs_exporter_stress_test.go:92: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/datasetexporter/logs_exporter_stress_test.go:92
        	Error:      	Received unexpected error:
        	            	cannot get DataSetExporter: cannot create newDatasetExporter: buffer settings are invalid: MaxLifetime 6225920 has to be at least 3 times smaller than PurgeOlderThan 0
        	Test:       	TestConsumeLogsManyLogsShouldSucceed
    logs_exporter_stress_test.go:137: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/datasetexporter/logs_exporter_stress_test.go:137
        	Error:      	Should be true
        	Test:       	TestConsumeLogsManyLogsShouldSucceed
    logs_exporter_stress_test.go:140: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/datasetexporter/logs_exporter_stress_test.go:140
        	Error:      	Not equal: 
        	            	expected: 0x30d40
        	            	actual  : 0x0
        	Test:       	TestConsumeLogsManyLogsShouldSucceed
        	Messages:   	processed items
    logs_exporter_stress_test.go:141: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/datasetexporter/logs_exporter_stress_test.go:141
        	Error:      	Not equal: 
        	            	expected: 0x30d40
        	            	actual  : 0x0
        	Test:       	TestConsumeLogsManyLogsShouldSucceed
        	Messages:   	unique items

=== FAIL: . TestConsumeLogsManyLogsShouldSucceed (re-run 1) (2.00s)
    logs_exporter_stress_test.go:92: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/datasetexporter/logs_exporter_stress_test.go:92
        	Error:      	Received unexpected error:
        	            	cannot get DataSetExporter: cannot create newDatasetExporter: buffer settings are invalid: MaxLifetime 62[259](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/8743341054/job/23993767562?pr=32529#step:5:260)20 has to be at least 3 times smaller than PurgeOlderThan 0
        	Test:       	TestConsumeLogsManyLogsShouldSucceed
    logs_exporter_stress_test.go:137: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/datasetexporter/logs_exporter_stress_test.go:137
        	Error:      	Should be true
        	Test:       	TestConsumeLogsManyLogsShouldSucceed
    logs_exporter_stress_test.go:140: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/datasetexporter/logs_exporter_stress_test.go:140
        	Error:      	Not equal: 
        	            	expected: 0x30d40
        	            	actual  : 0x0
        	Test:       	TestConsumeLogsManyLogsShouldSucceed
        	Messages:   	processed items
    logs_exporter_stress_test.go:141: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/datasetexporter/logs_exporter_stress_test.go:141
        	Error:      	Not equal: 
        	            	expected: 0x30d40
        	            	actual  : 0x0
        	Test:       	TestConsumeLogsManyLogsShouldSucceed
        	Messages:   	unique items

DONE 2 runs, 84 tests, 2 failures in 8.602s
make[2]: *** [../../Makefile.Common:142: mod-integration-test] Error 1
make[1]: *** [Makefile:165: exporter/datasetexporter] Error 2
make: *** [Makefile:122: gointegration-test] Error 2
make[1]: Leaving directory '/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib'
@crobert-1 crobert-1 added the needs triage New item requiring triage label Apr 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@atoulme atoulme removed the needs triage New item requiring triage label Apr 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jun 19, 2024
@martin-majlis-s1 martin-majlis-s1 mentioned this issue Jun 20, 2024
Merged
@mx-psi mx-psi closed this as completed in df2dff1 Jun 24, 2024
tomasmota pushed a commit to SpringerPE/opentelemetry-collector-contrib that referenced this issue Jul 1, 2024
@martin-majlis-s1 @crobert-1
@dmitryax @kernelpanic77 @evan-bradley @TylerHelmuth @codeboten @pjanotti @jmacd @hardproblems @tomasmota
[exporter/datasetexporter] Upgrade to dataset-go v0.19.0 (open-teleme…
0de7e88 
…try#33675)

**Description:** This PR is upgrading dataset-go to version v0.19.0 -
https://github.com/scalyr/dataset-go/releases/tag/v0.19.0

This PR is also fixing:
* open-telemetry#33498 - config validation is not called during conversion, therefore
I had to remove tests from logs and trace exporter. These tests are now
moved to the factory.
* open-telemetry#32533 - fixing failing integration tests, that were never updated and
therefore the configuration contained invalid values

**Link to tracking Issue:** open-telemetry#33498, open-telemetry#32533, open-telemetry#33675

**Testing:** Unit tests and integration tests.

**Documentation:** <Describe the documentation added.>

fixes open-telemetry#32533

---------

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Co-authored-by: Curtis Robert <crobert@splunk.com>
Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
Co-authored-by: Ishan Shanware <shanware.ishan@gmail.com>
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Co-authored-by: Paulo Janotti <pjanotti@splunk.com>
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
Co-authored-by: Rong Hu <hardproblems@users.noreply.github.com>
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Jul 11, 2024
@martin-majlis-s1 @crobert-1
@dmitryax @kernelpanic77 @evan-bradley @TylerHelmuth @codeboten @pjanotti @jmacd @hardproblems @cparkins
[exporter/datasetexporter] Upgrade to dataset-go v0.19.0 (open-teleme…
ef297fa 
…try#33675)

**Description:** This PR is upgrading dataset-go to version v0.19.0 -
https://github.com/scalyr/dataset-go/releases/tag/v0.19.0

This PR is also fixing:
* open-telemetry#33498 - config validation is not called during conversion, therefore
I had to remove tests from logs and trace exporter. These tests are now
moved to the factory.
* open-telemetry#32533 - fixing failing integration tests, that were never updated and
therefore the configuration contained invalid values

**Link to tracking Issue:** open-telemetry#33498, open-telemetry#32533, open-telemetry#33675

**Testing:** Unit tests and integration tests.

**Documentation:** <Describe the documentation added.>

fixes open-telemetry#32533

---------

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Co-authored-by: Curtis Robert <crobert@splunk.com>
Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
Co-authored-by: Ishan Shanware <shanware.ishan@gmail.com>
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Co-authored-by: Paulo Janotti <pjanotti@splunk.com>
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
Co-authored-by: Rong Hu <hardproblems@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exporter/dataset Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[exporter/datasetexporter] Upgrade to dataset-go v0.19.0 scalyr/opentelemetry-collector-contrib
2 participants
@atoulme @crobert-1