[exporter/elasticsearch] Make retry statuses configurable and default to 429 only #32584
Comments
carsonip
added
enhancement
|
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
|
It looks like the current thought, from what I'm gathering in the PR discussion, is that the default will stay the same for now, with warnings that functionality will change in the near future. A code owner was involved in this discussion and has signed off, so I'm removing |
|
#32585 will add the config option and another PR in the future will change the default. |
Previously, the status codes that trigger retries were hardcoded to be 429, 500, 502, 503, 504. It is now configurable using `retry.retry_on_status`, and defaults to `[429, 500, 502, 503, 504]` to avoid a breaking change. To avoid duplicates, it is recommended to configure `retry.retry_on_status` to `[429]`, which would be the default in a future version. Part of #32584 --------- Co-authored-by: Vishal Raj <vishal.raj@elastic.co> Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
…etry#32585) Previously, the status codes that trigger retries were hardcoded to be 429, 500, 502, 503, 504. It is now configurable using `retry.retry_on_status`, and defaults to `[429, 500, 502, 503, 504]` to avoid a breaking change. To avoid duplicates, it is recommended to configure `retry.retry_on_status` to `[429]`, which would be the default in a future version. Part of open-telemetry#32584 --------- Co-authored-by: Vishal Raj <vishal.raj@elastic.co> Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
|
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Component(s)
exporter/elasticsearch
Is your feature request related to a problem? Please describe.
Elasticsearch exporter retries on 500, 502, 503, 504, 429 by default, on both request level and document level. This is not ideal and may lead to duplicates.
Describe the solution you'd like
The retriable statuses should be configurable such that users may decide whether they prefer guaranteed delivery or no duplicates. It should default to retrying on 429 only.
Additional context
Integration tests need to be updated since it is testing with document level 500s now.
The text was updated successfully, but these errors were encountered: