Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[extension/googleclientauth] Support ID-token #33185

Closed
rinx opened this issue May 22, 2024 · 1 comment
Closed

[extension/googleclientauth] Support ID-token #33185

rinx opened this issue May 22, 2024 · 1 comment
Labels
enhancement New feature or request extension/googleclientauth

Comments

@rinx
Copy link
Contributor

rinx commented May 22, 2024 •
edited
Loading

Component(s)

extension/googleclientauth

Is your feature request related to a problem? Please describe.

To send telemetry to backend services behind Google's Cloud IAP or Cloud Run, I need an authentication extension that supports Google-signed ID token.

Describe the solution you'd like

Support ID-token type in Google Client Auth extension.

I've sent a PR to the repository. GoogleCloudPlatform/opentelemetry-operations-go#851
If it merged into the main branch and released, the feature will be available by updating the extension/googleclientauthextension/go.mod.

Describe alternatives you've considered

No response

Additional context

No response
@rinx rinx added enhancement New feature or request needs triage New item requiring triage labels May 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@dashpole dashpole removed the needs triage New item requiring triage label May 22, 2024
@github-actions github-actions bot mentioned this issue May 28, 2024
Open
rinx added a commit to rinx/opentelemetry-collector-contrib that referenced this issue Jun 11, 2024
@rinx
chore-deps(googleclientauthextension): update v0.48.0 of
087c9ab 
github.com/GoogleCloudPlatform/opentelemetry-operations-go/extension/googleclientauthextension

Closes: open-telemetry#33185

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
rinx added a commit to rinx/opentelemetry-collector-contrib that referenced this issue Jun 11, 2024
@rinx
docs(googleclientauthextension): update README
16cc2fc 
Refs: open-telemetry#33185
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx rinx mentioned this issue Jun 11, 2024
Merged
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Jul 11, 2024
@rinx @cparkins
[extension/googleclientauth] Update github.com/GoogleCloudPlatform/op…
ece0547 
…entelemetry-operations-go v0.48.0 (open-telemetry#33493)

Update
github.com/GoogleCloudPlatform/opentelemetry-operations-go/extension/googleclientauthextension
to v0.48.0.

This update includes support for Google-signed ID token.

https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/releases/tag/v0.48.0

Closes open-telemetry#33185

The documents about googleclientauth extension also updated.

---------

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request extension/googleclientauth
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rinx @dashpole