Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/vcenter] Additional metrics for vCenter receiver #33607

Closed
4 tasks done
BominRahmani opened this issue Jun 18, 2024 · 2 comments
Closed
4 tasks done

[receiver/vcenter] Additional metrics for vCenter receiver #33607

BominRahmani opened this issue Jun 18, 2024 · 2 comments
Labels
enhancement New feature or request receiver/vcenter

Comments

@BominRahmani
Copy link
Contributor

BominRahmani commented Jun 18, 2024 •
edited
Loading

Component(s)

receiver/vcenter

Is your feature request related to a problem? Please describe.

There are various metrics that we don't currently capture or could capture at a higher level.

Describe the solution you'd like

These metrics can most aptly be categorized under three categories:

Datacenter

- vcenter.datacenter.cluster.count                 status={red/green/yellow}
- vcenter.datacenter.vm.count                      status={red/green/yellow} power_state={on/off/suspended}
- vcenter.datacenter.datastore.count               status={red/green/yellow}
- vcenter.datacenter.host.count                    status={red/green/yellow} power_state={on/off}
- vcenter.datacenter.disk.space                    disk_state={available/used}
- vcenter.datacenter.cpu.limit
- vcenter.datacenter.memory.limit

Some of these proposed metrics may resemble existing ones, such as vcenter.datacenter.vm.count, which is similar to the currently captured vcenter.cluster.vm.count. However, the proposed metric aggregates through these alongside other vm's that may exist outside a cluster level. In effect providing a total/aggregated look into how many vms exist under that datacenter.

Host

- vcenter.host.network.packet.drop.rate    direction={transmitted/received}
- vcenter.host.cpu.capacity                reserved={true/false}

Resource pool

- vcenter.resource_pool.memory.swapped
- vcenter.resource_pool.memory.ballooned
- vcenter.resource_pool.memory.private
- vcenter.resource_pool.memory.shared
- vcenter.resource_pool.memory.usage          (currently exists: alteration -> type={guest/host/overhead})

Virtual machine

- vcenter.vm.cpu.readiness

If approved, I can split these enhancements out into 4 separate PR's.

Describe alternatives you've considered

No response

Additional context

No response
@BominRahmani BominRahmani added enhancement New feature or request needs triage New item requiring triage labels Jun 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@BominRahmani BominRahmani mentioned this issue Jun 18, 2024
Merged
@crobert-1
Copy link
Member

Removing needs triage based upon code owner responding 👍 to this issue.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Jun 18, 2024
@BominRahmani BominRahmani mentioned this issue Jun 19, 2024
Merged
This was referenced Jun 19, 2024
Open
Open
Open
Open
Open
Open
@BominRahmani BominRahmani mentioned this issue Jun 25, 2024
Merged
djaglowski pushed a commit that referenced this issue Jul 1, 2024
@BominRahmani
[receiver/vcenter] Adds vCenter VM CPU readiness metric (#33608)
0e9dde7 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
This PR adds the `vcenter.vm.cpu.readiness` metric.
More information on this metric can be found
[here](https://vdc-repo.vmware.com/vmwb-repository/dcr-public/d1902b0e-d479-46bf-8ac9-cee0e31e8ec0/07ce8dbd-db48-4261-9b8f-c6d3ad8ba472/vim.vm.Summary.QuickStats.html).
**Link to tracking Issue:** #33607

**Testing:** <Describe what testing was performed and which tests were
added.>
The metric was scraped from a test vCenter environment, and golden test
files were updated to reflect the addition of the metric.

**Documentation:** <Describe the documentation added.>
Documentation was updated according to the metadata.yaml
djaglowski pushed a commit that referenced this issue Jul 1, 2024
@BominRahmani
[receiver/vcenter] Add vCenter Host metrics (dropped packet rate + ca…
2604193 
…pacity) (#33646)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
The following PR adds the following metrics
```
vcenter.host.network.packet.drop.rate
vcenter.host.cpu.capacity
vcenter.host.cpu.reserve.capacity
```
These metrics can be found in the following links respectively:
[errorTx and
errorRx](https://vdc-repo.vmware.com/vmwb-repository/dcr-public/d1902b0e-d479-46bf-8ac9-cee0e31e8ec0/07ce8dbd-db48-4261-9b8f-c6d3ad8ba472/network_counters.html)
[reservedCapacity and
totalCapacity](https://vdc-repo.vmware.com/vmwb-repository/dcr-public/d1902b0e-d479-46bf-8ac9-cee0e31e8ec0/07ce8dbd-db48-4261-9b8f-c6d3ad8ba472/cpu_counters.html)

**Link to tracking Issue:** #33607

**Testing:** <Describe what testing was performed and which tests were
added.>
Tested against a live environment to scrape added metrics, and updated
golden test files.

**Documentation:** <Describe the documentation added.>
Updated documentation through mdatagen.
@BominRahmani BominRahmani mentioned this issue Jul 7, 2024
Merged
djaglowski pushed a commit that referenced this issue Jul 9, 2024
@BominRahmani
[receiver/vcenter] Adds additional resource pool metrics (#33741)
9188fa4 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
The following PR adds these
[metrics](https://vdc-repo.vmware.com/vmwb-repository/dcr-public/d1902b0e-d479-46bf-8ac9-cee0e31e8ec0/07ce8dbd-db48-4261-9b8f-c6d3ad8ba472/vim.ResourcePool.Summary.QuickStats.html)
```
- vcenter.resource_pool.memory.swapped
- vcenter.resource_pool.memory.ballooned
- vcenter.resource_pool.memory.granted {memory_granted: shared / private}
```

It also adds the attribute `memory_usage_type` and splits up the
`vcenter.resource_pool.memory.usage` metric into the following
attributes: `host, guest, overhead`

**Link to tracking Issue:**  #33607

**Testing:** <Describe what testing was performed and which tests were
added.>
Golden files were generated to show the addition of the new metrics.

**Documentation:** 
Documentation generated by `make generate`.
djaglowski pushed a commit that referenced this issue Jul 10, 2024
@BominRahmani
[receiver/vcenter] Adds Datacenter metrics (#33933)
5b290f0 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
The following PR introduces multiple different metrics at a datacenter
level. It takes advantage of processing thats already done at the
cluster, host, vm, and datastore level in order to aggregate datacenter
level metrics.

```
- vcenter.datacenter.cluster.count                 status={red/green/yellow, gray}
- vcenter.datacenter.vm.count                      status={red/green/yellow, gray} power_state={on/off/suspended}
- vcenter.datacenter.datastore.count               status={red/green/yellow, gray}
- vcenter.datacenter.host.count                    status={red/green/yellow, gray} power_state={on/off/standby/unknown}
- vcenter.datacenter.disk.space                    disk_state={used/available}
- vcenter.datacenter.cpu.limit
- vcenter.datacenter.memory.limit
```

**Link to tracking Issue:** #33607

**Testing:** <Describe what testing was performed and which tests were
added.>
Tested against a live environment to make sure all values matched up.
Golden testing files have been updated.

**Documentation:** <Describe the documentation added.>
All documentation was generated through mdatagen
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-collector-contrib that referenced this issue Jul 11, 2024
@BominRahmani
[receiver/vcenter] Adds Datacenter metrics (open-telemetry#33933)
322f6ef 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
The following PR introduces multiple different metrics at a datacenter
level. It takes advantage of processing thats already done at the
cluster, host, vm, and datastore level in order to aggregate datacenter
level metrics.

```
- vcenter.datacenter.cluster.count                 status={red/green/yellow, gray}
- vcenter.datacenter.vm.count                      status={red/green/yellow, gray} power_state={on/off/suspended}
- vcenter.datacenter.datastore.count               status={red/green/yellow, gray}
- vcenter.datacenter.host.count                    status={red/green/yellow, gray} power_state={on/off/standby/unknown}
- vcenter.datacenter.disk.space                    disk_state={used/available}
- vcenter.datacenter.cpu.limit
- vcenter.datacenter.memory.limit
```

**Link to tracking Issue:** open-telemetry#33607

**Testing:** <Describe what testing was performed and which tests were
added.>
Tested against a live environment to make sure all values matched up.
Golden testing files have been updated.

**Documentation:** <Describe the documentation added.>
All documentation was generated through mdatagen
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-collector-contrib that referenced this issue Jul 11, 2024
@BominRahmani
[receiver/vcenter] Adds Datacenter metrics (open-telemetry#33933)
c7670d8 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
The following PR introduces multiple different metrics at a datacenter
level. It takes advantage of processing thats already done at the
cluster, host, vm, and datastore level in order to aggregate datacenter
level metrics.

```
- vcenter.datacenter.cluster.count                 status={red/green/yellow, gray}
- vcenter.datacenter.vm.count                      status={red/green/yellow, gray} power_state={on/off/suspended}
- vcenter.datacenter.datastore.count               status={red/green/yellow, gray}
- vcenter.datacenter.host.count                    status={red/green/yellow, gray} power_state={on/off/standby/unknown}
- vcenter.datacenter.disk.space                    disk_state={used/available}
- vcenter.datacenter.cpu.limit
- vcenter.datacenter.memory.limit
```

**Link to tracking Issue:** open-telemetry#33607

**Testing:** <Describe what testing was performed and which tests were
added.>
Tested against a live environment to make sure all values matched up.
Golden testing files have been updated.

**Documentation:** <Describe the documentation added.>
All documentation was generated through mdatagen
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Jul 11, 2024
@BominRahmani @cparkins
[receiver/vcenter] Adds vCenter VM CPU readiness metric (open-telemet…
9082642 
…ry#33608)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
This PR adds the `vcenter.vm.cpu.readiness` metric.
More information on this metric can be found
[here](https://vdc-repo.vmware.com/vmwb-repository/dcr-public/d1902b0e-d479-46bf-8ac9-cee0e31e8ec0/07ce8dbd-db48-4261-9b8f-c6d3ad8ba472/vim.vm.Summary.QuickStats.html).
**Link to tracking Issue:** open-telemetry#33607

**Testing:** <Describe what testing was performed and which tests were
added.>
The metric was scraped from a test vCenter environment, and golden test
files were updated to reflect the addition of the metric.

**Documentation:** <Describe the documentation added.>
Documentation was updated according to the metadata.yaml
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Jul 11, 2024
@BominRahmani @cparkins
[receiver/vcenter] Add vCenter Host metrics (dropped packet rate + ca…
0214999 
…pacity) (open-telemetry#33646)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
The following PR adds the following metrics
```
vcenter.host.network.packet.drop.rate
vcenter.host.cpu.capacity
vcenter.host.cpu.reserve.capacity
```
These metrics can be found in the following links respectively:
[errorTx and
errorRx](https://vdc-repo.vmware.com/vmwb-repository/dcr-public/d1902b0e-d479-46bf-8ac9-cee0e31e8ec0/07ce8dbd-db48-4261-9b8f-c6d3ad8ba472/network_counters.html)
[reservedCapacity and
totalCapacity](https://vdc-repo.vmware.com/vmwb-repository/dcr-public/d1902b0e-d479-46bf-8ac9-cee0e31e8ec0/07ce8dbd-db48-4261-9b8f-c6d3ad8ba472/cpu_counters.html)

**Link to tracking Issue:** open-telemetry#33607

**Testing:** <Describe what testing was performed and which tests were
added.>
Tested against a live environment to scrape added metrics, and updated
golden test files.

**Documentation:** <Describe the documentation added.>
Updated documentation through mdatagen.
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Jul 11, 2024
@BominRahmani @cparkins
[receiver/vcenter] Adds additional resource pool metrics (open-teleme…
bf82201 
…try#33741)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
The following PR adds these
[metrics](https://vdc-repo.vmware.com/vmwb-repository/dcr-public/d1902b0e-d479-46bf-8ac9-cee0e31e8ec0/07ce8dbd-db48-4261-9b8f-c6d3ad8ba472/vim.ResourcePool.Summary.QuickStats.html)
```
- vcenter.resource_pool.memory.swapped
- vcenter.resource_pool.memory.ballooned
- vcenter.resource_pool.memory.granted {memory_granted: shared / private}
```

It also adds the attribute `memory_usage_type` and splits up the
`vcenter.resource_pool.memory.usage` metric into the following
attributes: `host, guest, overhead`

**Link to tracking Issue:**  open-telemetry#33607

**Testing:** <Describe what testing was performed and which tests were
added.>
Golden files were generated to show the addition of the new metrics.

**Documentation:** 
Documentation generated by `make generate`.
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Jul 11, 2024
@BominRahmani @cparkins
[receiver/vcenter] Adds Datacenter metrics (open-telemetry#33933)
1c92462 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
The following PR introduces multiple different metrics at a datacenter
level. It takes advantage of processing thats already done at the
cluster, host, vm, and datastore level in order to aggregate datacenter
level metrics.

```
- vcenter.datacenter.cluster.count                 status={red/green/yellow, gray}
- vcenter.datacenter.vm.count                      status={red/green/yellow, gray} power_state={on/off/suspended}
- vcenter.datacenter.datastore.count               status={red/green/yellow, gray}
- vcenter.datacenter.host.count                    status={red/green/yellow, gray} power_state={on/off/standby/unknown}
- vcenter.datacenter.disk.space                    disk_state={used/available}
- vcenter.datacenter.cpu.limit
- vcenter.datacenter.memory.limit
```

**Link to tracking Issue:** open-telemetry#33607

**Testing:** <Describe what testing was performed and which tests were
added.>
Tested against a live environment to make sure all values matched up.
Golden testing files have been updated.

**Documentation:** <Describe the documentation added.>
All documentation was generated through mdatagen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request receiver/vcenter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BominRahmani @crobert-1