Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[processor/resourcedetection] Add host.ip addresses detection #24450

Merged
merged 19 commits into from
Nov 30, 2023
Merged

[processor/resourcedetection] Add host.ip addresses detection #24450

merged 19 commits into from
Nov 30, 2023

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jul 24, 2023 •
edited
Loading

Description:

Adds detection for host.ip.

Relates to open-telemetry/semantic-conventions/pull/203

Fixes #24765

@mx-psi mx-psi mentioned this pull request Jul 24, 2023
Merged
@mx-psi mx-psi changed the title [processor/resourcedetection] Add host.ipv4.addresses and host.ipv6 addresses detection [processor/resourcedetection] Add host.ip addresses detection Jul 31, 2023
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 17, 2023
@mx-psi mx-psi removed the Stale label Aug 28, 2023
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Sep 12, 2023
@mx-psi mx-psi removed the Stale label Sep 12, 2023
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Sep 27, 2023
@mx-psi mx-psi removed the Stale label Sep 27, 2023
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 12, 2023
@mx-psi mx-psi removed the Stale label Oct 16, 2023
@mx-psi mx-psi marked this pull request as ready for review October 16, 2023 14:02
@mx-psi mx-psi requested a review from a team as a code owner October 16, 2023 14:02
@mx-psi mx-psi requested a review from frzifus October 16, 2023 14:20
@mx-psi
Copy link
Member Author

mx-psi commented Oct 16, 2023

cc @ChrsMark

ChrsMark
ChrsMark approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Code owners should also have a look :)

@mx-psi mx-psi requested a review from frzifus October 24, 2023 13:19
@mx-psi
Copy link
Member Author

mx-psi commented Oct 24, 2023

@frzifus can you take another look?

frzifus
frzifus approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@frzifus frzifus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@mx-psi mx-psi requested a review from dmitryax October 24, 2023 15:48
@mx-psi mx-psi requested a review from dmitryax November 6, 2023 13:07
@mx-psi
Copy link
Member Author

mx-psi commented Nov 15, 2023

@dmitryax could you take another look?

@mx-psi mx-psi merged commit 554dee1 into open-telemetry:main Nov 30, 2023
83 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 30, 2023
@mx-psi mx-psi mentioned this pull request Nov 30, 2023
Merged
@mx-psi mx-psi mentioned this pull request Jan 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoulme atoulme atoulme approved these changes

@dmitryax dmitryax dmitryax approved these changes

@frzifus frzifus frzifus approved these changes

@ChrsMark ChrsMark ChrsMark approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

Assignees

@MovieStoreGuy MovieStoreGuy

Labels
internal/metadataproviders processor/resourcedetection Resource detection processor
Projects
None yet
Milestone
v0.90.1
Development

Successfully merging this pull request may close these issues.

[processor/resourcedetection] Add host.ip to system detector
6 participants
@mx-psi @atoulme @dmitryax @frzifus @ChrsMark @MovieStoreGuy