Turn on disable APM stats in the Datadog Exporter feature gate by default #31219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
approved these changes
Feb 13, 2024
dineshg13
reviewed
Feb 13, 2024
mx-psi
reviewed
Feb 14, 2024
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
mx-psi
approved these changes
Feb 14, 2024
dineshg13
approved these changes
Feb 14, 2024
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…ault (open-telemetry#31219) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Changes noAPMStatsFeatureGate to beta in order to disable APM stats in the exporter by default **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> --------- Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
dmitryax
pushed a commit
that referenced
this pull request
Mar 29, 2024
) **Description:** We disabled APM Stats computation in the Datadog Exporter by default in #31219. This PR adds a warn log in the Datadog Exporter traces pipeline to bring visibility to this breaking change and links to migration documentation. The log shows as follows: ``` ❯ ./bin/otelcontribcol_darwin_arm64 2024-03-26T13:29:58.641-0400 info service@v0.96.1-0.20240322165517-15201f1e5967/telemetry.go:55 Setting up own telemetry... 2024-03-26T13:29:58.641-0400 info service@v0.96.1-0.20240322165517-15201f1e5967/telemetry.go:97 Serving metrics {"address": ":8888", "level": "Basic"} 2024-03-26T13:29:58.641-0400 debug exporter@v0.96.1-0.20240322165517-15201f1e5967/exporter.go:273 Beta component. May change in the future. {"kind": "exporter", "data_type": "traces", "name": "datadog/api"} 2024-03-26T13:29:58.641-0400 warn datadogexporter@v0.96.0/factory.go:386 Trace metrics are now disabled in the Datadog Exporter by default. To continue receiving Trace Metrics, configure the Datadog Connector or disable the feature gate. {"kind": "exporter", "data_type": "traces", "name": "datadog/api", "documentation": "https://docs.datadoghq.com/opentelemetry/guide/migration/", "feature gate ID": "exporter.datadogexporter.DisableAPMStats"} ```
ycombinator
pushed a commit
to ycombinator/opentelemetry-collector-contrib
that referenced
this pull request
Apr 9, 2024
…n-telemetry#31981) **Description:** We disabled APM Stats computation in the Datadog Exporter by default in open-telemetry#31219. This PR adds a warn log in the Datadog Exporter traces pipeline to bring visibility to this breaking change and links to migration documentation. The log shows as follows: ``` ❯ ./bin/otelcontribcol_darwin_arm64 2024-03-26T13:29:58.641-0400 info service@v0.96.1-0.20240322165517-15201f1e5967/telemetry.go:55 Setting up own telemetry... 2024-03-26T13:29:58.641-0400 info service@v0.96.1-0.20240322165517-15201f1e5967/telemetry.go:97 Serving metrics {"address": ":8888", "level": "Basic"} 2024-03-26T13:29:58.641-0400 debug exporter@v0.96.1-0.20240322165517-15201f1e5967/exporter.go:273 Beta component. May change in the future. {"kind": "exporter", "data_type": "traces", "name": "datadog/api"} 2024-03-26T13:29:58.641-0400 warn datadogexporter@v0.96.0/factory.go:386 Trace metrics are now disabled in the Datadog Exporter by default. To continue receiving Trace Metrics, configure the Datadog Connector or disable the feature gate. {"kind": "exporter", "data_type": "traces", "name": "datadog/api", "documentation": "https://docs.datadoghq.com/opentelemetry/guide/migration/", "feature gate ID": "exporter.datadogexporter.DisableAPMStats"} ```
rimitchell
pushed a commit
to rimitchell/opentelemetry-collector-contrib
that referenced
this pull request
May 8, 2024
…n-telemetry#31981) **Description:** We disabled APM Stats computation in the Datadog Exporter by default in open-telemetry#31219. This PR adds a warn log in the Datadog Exporter traces pipeline to bring visibility to this breaking change and links to migration documentation. The log shows as follows: ``` ❯ ./bin/otelcontribcol_darwin_arm64 2024-03-26T13:29:58.641-0400 info service@v0.96.1-0.20240322165517-15201f1e5967/telemetry.go:55 Setting up own telemetry... 2024-03-26T13:29:58.641-0400 info service@v0.96.1-0.20240322165517-15201f1e5967/telemetry.go:97 Serving metrics {"address": ":8888", "level": "Basic"} 2024-03-26T13:29:58.641-0400 debug exporter@v0.96.1-0.20240322165517-15201f1e5967/exporter.go:273 Beta component. May change in the future. {"kind": "exporter", "data_type": "traces", "name": "datadog/api"} 2024-03-26T13:29:58.641-0400 warn datadogexporter@v0.96.0/factory.go:386 Trace metrics are now disabled in the Datadog Exporter by default. To continue receiving Trace Metrics, configure the Datadog Connector or disable the feature gate. {"kind": "exporter", "data_type": "traces", "name": "datadog/api", "documentation": "https://docs.datadoghq.com/opentelemetry/guide/migration/", "feature gate ID": "exporter.datadogexporter.DisableAPMStats"} ```
nslaughter
pushed a commit
to nslaughter/opentelemetry-collector-contrib
that referenced
this pull request
May 23, 2024
…ault (open-telemetry#31219) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Changes noAPMStatsFeatureGate to beta in order to disable APM stats in the exporter by default **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> --------- Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changes noAPMStatsFeatureGate to beta in order to disable APM stats in the exporter by default
Link to tracking Issue:
Testing:
Documentation: