[processor/deltatocumulative]: bugfix - permit advancing start-time #31365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh0rez
force-pushed
the
deltatocumulative-advancing-starttime
branch
from
9893da1
to
9163f48
Compare
26 tasks
|
Imagine this situation:
And T1 < T2 < T3 < T4. The interval from T2 to T3 is unaccounted for and even if a corresponding data point arrives later it would be ignored. Or maybe it gets lost for some reason. What do you think about a metric that tracks this unaccounted time? Since there are no more resets, it would replace the |
|
@ethercrow I like that, but I think it's out of scope for this PR (given the metrics one isn't even merged). But lets add it later 👍 |
|
@RichieSams @djaglowski please take a look! |
djaglowski
approved these changes
Feb 28, 2024
|
Ah, they beat me to it. Good find :) |
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…pen-telemetry#31365) **Description:** <Describe what has changed.> The [spec](https://opentelemetry.io/docs/specs/otel/metrics/data-model/#sums-delta-to-cumulative) allows the `StartTimestamp` of a delta stream to advance over time, without affecting the aggregation. Previously, the running counter was reset with each start-time change. This was violating the spec and also effectively prevented meaningful aggregation as series were reset all the time. **Testing:** A test-case was modified to explicitly check this behavior is permitted and handled correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The spec allows the
StartTimestampof a delta stream to advance over time, without affecting the aggregation.Previously, the running counter was reset with each start-time change. This was violating the spec and also effectively prevented meaningful aggregation as series were reset all the time.
Testing:
A test-case was modified to explicitly check this behavior is permitted and handled correctly.