[exporter/datadog] include version in stats payloads from dd connector #31454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
dineshg13,
liustanley,
mackjmr,
mx-psi and
songy23
dineshg13
approved these changes
Feb 27, 2024
songy23
approved these changes
Feb 27, 2024
jdgumz
reviewed
Feb 27, 2024
| @@ -262,6 +262,8 @@ func (f *factory) consumeStatsPayload(ctx context.Context, statsIn <-chan []byte | |||
| csp.TracerVersion = tracerVersion | |||
| } | |||
| } | |||
| // The DD Connector doesn't set the agent version, so we'll set it here | |||
jdgumz
approved these changes
Feb 27, 2024
songy23
added
the
ready to merge
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
open-telemetry#31454) **Description:** The dd connector doesn't attach the version of the collector that generated the stats - to ensure the version is attached the exporter should attach the version. This improves the debugging experience by giving improved visibility into exactly which collector versions are sending payloads. **Testing:** Modified integration test to ensure coverage of new line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The dd connector doesn't attach the version of the collector that generated the stats - to ensure the version is attached the exporter should attach the version. This improves the debugging experience by giving improved visibility into exactly which collector versions are sending payloads.
Link to tracking Issue:
Testing:
Modified integration test to ensure coverage of new line
Documentation: