Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/stanza] Improve timestamp parsing documentation #31490

Merged

Conversation

djaglowski
Copy link
Member

This PR adds explicit sections to describe the meaning of the various layout_types along with a table showing the available strptime and gotime directives.

@djaglowski djaglowski marked this pull request as ready for review February 28, 2024 18:35
@djaglowski djaglowski requested a review from a team as a code owner February 28, 2024 18:35
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

.chloggen/pkg-stanza-timestamp-docs.yaml Show resolved Hide resolved
@djaglowski djaglowski merged commit 5cddf62 into open-telemetry:main Feb 28, 2024
143 of 144 checks passed
@djaglowski djaglowski deleted the pkg-stanza-timestamp-docs branch February 28, 2024 21:12
@github-actions github-actions bot added this to the next release milestone Feb 28, 2024
XinRanZhAWS pushed a commit to XinRanZhAWS/opentelemetry-collector-contrib that referenced this pull request Mar 13, 2024
…31490)

This PR adds explicit sections to describe the meaning of the various
`layout_types` along with a table showing the available `strptime` and
`gotime` directives.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants