[exporter/loadbalancing] Change config fields to use snake_case #32331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
fix-load-balancer-exporter
branch
from
b7d4960
to
2d52fce
Compare
dmitryax
force-pushed
the
fix-load-balancer-exporter
branch
from
2d52fce
to
a280f5c
Compare
|
I know it's a pain, but given that this component is in "Beta" stability, shouldn't we do the rename via a feature gate? |
|
The feature was introduced only in 0.97.0 #27588 so I expect it's not widely used yet. And I want to unblock #32328 sooner to avoid any other issues like this merged in. So I'd rather make it as a breaking change but happy to hear what others think cc @jpkrohling @open-telemetry/collector-contrib-approvers |
Makes sense to me 🚀 |
andrzej-stencel
approved these changes
Apr 11, 2024
dmitryax
force-pushed
the
fix-load-balancer-exporter
branch
from
a280f5c
to
f416b78
Compare
|
Updated README |
crobert-1
reviewed
Apr 11, 2024
|
Thanks @crobert-1. Updated |
bryan-aguilar
approved these changes
Apr 11, 2024
| namespace: aws-namespace | ||
| serviceName: aws-otel-col-service-name | ||
| service_name: aws-otel-col-service-name |
There was a problem hiding this comment.
Suggested change
| service_name: aws-otel-col-service-name | |
| service_name: otel-col-service-name |
Teeny tiny nit. Vendor agnostic right :)
There was a problem hiding this comment.
Should I change aws-namespace as well? It's pretty hard to make AWS Cloud Map resolver vendor agnostic :)
crobert-1
approved these changes
Apr 11, 2024
Change AWS Cloud map resolver config fields from camelCase to snake_case. The snake_case is required in OTel Collector config fields. It used to be enforced by tests in cmd/oteltestbedcol, but we had to disable them some time ago. Now, the tests are going to be enforced on every component independently. Hence, the camelCase config fields recently added with the bew AWS Cloud Map resolver has to be fixed.
Co-authored-by: Curtis Robert <crobert@splunk.com>
Co-authored-by: Curtis Robert <crobert@splunk.com>
dmitryax
force-pushed
the
fix-load-balancer-exporter
branch
from
75e869c
to
105494b
Compare
jpkrohling
approved these changes
Apr 12, 2024
rimitchell
pushed a commit
to rimitchell/opentelemetry-collector-contrib
that referenced
this pull request
May 8, 2024
…-telemetry#32331) Change AWS Cloud map resolver config fields from camelCase to snake_case. The snake_case is required in OTel Collector config fields. It used to be enforced by tests in cmd/oteltestbedcol, but we had to disable them some time ago. Now, the tests are going to be enforced on every component independently. Hence, the camelCase config fields recently added with the new AWS Cloud Map resolver has to be fixed. --------- Co-authored-by: Curtis Robert <crobert@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change AWS Cloud map resolver config fields from camelCase to snake_case.
The snake_case is required in OTel Collector config fields. It used to be enforced by tests in cmd/oteltestbedcol, but we had to disable them some time ago. Now, the tests are going to be enforced on every component independently. Hence, the camelCase config fields recently added with the new AWS Cloud Map resolver has to be fixed.