[internal/metadataproviders/azure] Fix memory leak on AKS #32574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobert-1
changed the title
crobert-1
commented
Apr 19, 2024
crobert-1
changed the title
crobert-1
added
processor/resourcedetection
github-actions
bot
requested review from
dineshg13,
liustanley,
mackjmr,
mx-psi and
songy23
|
I've added references to the resource detection processor and Datadog exporter as this internal library is used by both components, and they're both potential victims of the leak. |
songy23
approved these changes
Apr 19, 2024
mx-psi
approved these changes
Apr 22, 2024
rimitchell
pushed a commit
to rimitchell/opentelemetry-collector-contrib
that referenced
this pull request
May 8, 2024
…etry#32574) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> From [`client.Do` documentation](https://pkg.go.dev/net/http#Client.Do), a client's response can safely be ignored when an error is returned, but must be handled in all other cases, even when a response code is not 2XX. This fixes the internal AKS detection to properly close the response body in the case of a non-200 status returned. This also enables `goleak` on the `internal/metadata/azure` package which helps ensure no goroutines are being leaked. `goleak` is what detected this bug. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#30438 **Testing:** <Describe what testing was performed and which tests were added.> All existing tests are passing as well as added `goleak` check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
From
client.Dodocumentation, a client's response can safely be ignored when an error is returned, but must be handled in all other cases, even when a response code is not 2XX. This fixes the internal AKS detection to properly close the response body in the case of a non-200 status returned.This also enables
goleakon theinternal/metadata/azurepackage which helps ensure no goroutines are being leaked.goleakis what detected this bug.Link to tracking Issue:
#30438
Testing:
All existing tests are passing as well as added
goleakcheck.