[processor/groupbytrace] Fix groupbytrace metrics contain duplicate prefix #32698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frapschen
force-pushed
the
fix_groupbytrace_metrics_bug
branch
from
b0db183
to
010b228
Compare
jpkrohling
approved these changes
May 7, 2024
jpkrohling
added a commit
that referenced
this pull request
May 7, 2024
This is caused by #32698 , which apparently didn't fail with this. Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
rimitchell
pushed a commit
to rimitchell/opentelemetry-collector-contrib
that referenced
this pull request
May 8, 2024
…refix (open-telemetry#32698) The actual metrics generated by groupbytrace have duplicate prefix `processor_groupbytrace` error groupbytrace metrics: ``` # HELP otelcol_processor_groupbytrace_processor_groupbytrace_incomplete_releases Releases that are suspected to have been incomplete # TYPE otelcol_processor_groupbytrace_processor_groupbytrace_incomplete_releases counter otelcol_processor_groupbytrace_processor_groupbytrace_incomplete_releases{service_instance_id="ac4299e2-8c43-47df-bdd6-90028fb39cd1",service_name="otelcontribcol",service_version="0.99.0-dev"} 0 # HELP otelcol_processor_groupbytrace_processor_groupbytrace_num_events_in_queue Number of events currently in the queue # TYPE otelcol_processor_groupbytrace_processor_groupbytrace_num_events_in_queue gauge otelcol_processor_groupbytrace_processor_groupbytrace_num_events_in_queue{service_instance_id="ac4299e2-8c43-47df-bdd6-90028fb39cd1",service_name="otelcontribcol",service_version="0.99.0-dev"} 0 # HELP otelcol_processor_groupbytrace_processor_groupbytrace_num_traces_in_memory Number of traces currently in the in-memory storage # TYPE otelcol_processor_groupbytrace_processor_groupbytrace_num_traces_in_memory gauge otelcol_processor_groupbytrace_processor_groupbytrace_num_traces_in_memory{service_instance_id="ac4299e2-8c43-47df-bdd6-90028fb39cd1",service_name="otelcontribcol",service_version="0.99.0-dev"} 0 # HELP otelcol_processor_groupbytrace_processor_groupbytrace_spans_released Spans released to the next consumer # TYPE otelcol_processor_groupbytrace_processor_groupbytrace_spans_released counter otelcol_processor_groupbytrace_processor_groupbytrace_spans_released{service_instance_id="ac4299e2-8c43-47df-bdd6-90028fb39cd1",service_name="otelcontribcol",service_version="0.99.0-dev"} 20 # HELP otelcol_processor_groupbytrace_processor_groupbytrace_traces_evicted Traces evicted from the internal buffer # TYPE otelcol_processor_groupbytrace_processor_groupbytrace_traces_evicted counter otelcol_processor_groupbytrace_processor_groupbytrace_traces_evicted{service_instance_id="ac4299e2-8c43-47df-bdd6-90028fb39cd1",service_name="otelcontribcol",service_version="0.99.0-dev"} 0 # HELP otelcol_processor_groupbytrace_processor_groupbytrace_traces_released Traces released to the next consumer # TYPE otelcol_processor_groupbytrace_processor_groupbytrace_traces_released counter otelcol_processor_groupbytrace_processor_groupbytrace_traces_released{service_instance_id="ac4299e2-8c43-47df-bdd6-90028fb39cd1",service_name="otelcontribcol",service_version="0.99.0-dev"} 10 ```
rimitchell
pushed a commit
to rimitchell/opentelemetry-collector-contrib
that referenced
this pull request
May 8, 2024
This is caused by open-telemetry#32698 , which apparently didn't fail with this. Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jul 11, 2024
…refix (open-telemetry#32698) The actual metrics generated by groupbytrace have duplicate prefix `processor_groupbytrace` error groupbytrace metrics: ``` # HELP otelcol_processor_groupbytrace_processor_groupbytrace_incomplete_releases Releases that are suspected to have been incomplete # TYPE otelcol_processor_groupbytrace_processor_groupbytrace_incomplete_releases counter otelcol_processor_groupbytrace_processor_groupbytrace_incomplete_releases{service_instance_id="ac4299e2-8c43-47df-bdd6-90028fb39cd1",service_name="otelcontribcol",service_version="0.99.0-dev"} 0 # HELP otelcol_processor_groupbytrace_processor_groupbytrace_num_events_in_queue Number of events currently in the queue # TYPE otelcol_processor_groupbytrace_processor_groupbytrace_num_events_in_queue gauge otelcol_processor_groupbytrace_processor_groupbytrace_num_events_in_queue{service_instance_id="ac4299e2-8c43-47df-bdd6-90028fb39cd1",service_name="otelcontribcol",service_version="0.99.0-dev"} 0 # HELP otelcol_processor_groupbytrace_processor_groupbytrace_num_traces_in_memory Number of traces currently in the in-memory storage # TYPE otelcol_processor_groupbytrace_processor_groupbytrace_num_traces_in_memory gauge otelcol_processor_groupbytrace_processor_groupbytrace_num_traces_in_memory{service_instance_id="ac4299e2-8c43-47df-bdd6-90028fb39cd1",service_name="otelcontribcol",service_version="0.99.0-dev"} 0 # HELP otelcol_processor_groupbytrace_processor_groupbytrace_spans_released Spans released to the next consumer # TYPE otelcol_processor_groupbytrace_processor_groupbytrace_spans_released counter otelcol_processor_groupbytrace_processor_groupbytrace_spans_released{service_instance_id="ac4299e2-8c43-47df-bdd6-90028fb39cd1",service_name="otelcontribcol",service_version="0.99.0-dev"} 20 # HELP otelcol_processor_groupbytrace_processor_groupbytrace_traces_evicted Traces evicted from the internal buffer # TYPE otelcol_processor_groupbytrace_processor_groupbytrace_traces_evicted counter otelcol_processor_groupbytrace_processor_groupbytrace_traces_evicted{service_instance_id="ac4299e2-8c43-47df-bdd6-90028fb39cd1",service_name="otelcontribcol",service_version="0.99.0-dev"} 0 # HELP otelcol_processor_groupbytrace_processor_groupbytrace_traces_released Traces released to the next consumer # TYPE otelcol_processor_groupbytrace_processor_groupbytrace_traces_released counter otelcol_processor_groupbytrace_processor_groupbytrace_traces_released{service_instance_id="ac4299e2-8c43-47df-bdd6-90028fb39cd1",service_name="otelcontribcol",service_version="0.99.0-dev"} 10 ```
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jul 11, 2024
This is caused by open-telemetry#32698 , which apparently didn't fail with this. Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual metrics generated by groupbytrace have duplicate prefix
processor_groupbytraceerror groupbytrace metrics: