[pkg/stanza] expose max log size option for the container parser #33186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrsMark
force-pushed
the
container_parser_expose_max_recombine_log
branch
2 times, most recently
from
66fa2b8
to
5db4b20
Compare
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
ChrsMark
force-pushed
the
container_parser_expose_max_recombine_log
branch
from
5db4b20
to
1410ebf
Compare
djaglowski
approved these changes
May 22, 2024
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jul 11, 2024
…n-telemetry#33186) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> The [logsCollection](https://github.com/open-telemetry/opentelemetry-helm-charts/blob/ef0e1ac4f645cdbb9bd0108c76b1ed69e418430c/charts/opentelemetry-collector/values.yaml#L29C3-L37) Helm preset provides the option to set the `maxRecombineLogSize`. The `container` parser does not expose this option but rather sets it to `102400` by default internally. This PR is to make this option configurable so that the parser can be used in the [Helm preset seamlessly](open-telemetry/opentelemetry-helm-charts#1195). **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> Added. **Documentation:** <Describe the documentation added.> Updated. Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The logsCollection Helm preset provides the option to set the
maxRecombineLogSize.The
containerparser does not expose this option but rather sets it to102400by default internally.This PR is to make this option configurable so that the parser can be used in the Helm preset seamlessly.
Link to tracking Issue:
Testing: Added.
Documentation: Updated.