[cmd/telemetrygen] Add exemplars support for telemetrygen #33320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
codeboten
approved these changes
May 31, 2024
| }, | ||
| }, | ||
| { | ||
| name: "only-traceID", |
There was a problem hiding this comment.
is there a valid case for supporting only one of trace or span ID? I guess it could be used for edge case testing?
There was a problem hiding this comment.
The idea is indeed to allow for different test scenarios, like how a backend would behave in face of bad instrumentation.
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jul 11, 2024
…etry#33320) This PR adds support for passing a traceID and spanID to be used as exemplars on the generated data points. This was verified with an e2e test using OTel Collector and the debug exporter in detailed verbosity, resulting in this: ``` 2024-05-31T11:41:51.378+0200 info ResourceMetrics #0 Resource SchemaURL: https://opentelemetry.io/schemas/1.13.0 ScopeMetrics #0 ScopeMetrics SchemaURL: InstrumentationScope Metric #0 Descriptor: -> Name: gen -> Description: -> Unit: -> DataType: Gauge NumberDataPoints #0 StartTimestamp: 1970-01-01 00:00:00 +0000 UTC Timestamp: 2024-05-31 09:41:51.374564535 +0000 UTC Value: 0 Exemplars: Exemplar #0 -> Trace ID: ae87dadd90e9935a4bc9660628efd569 -> Span ID: 5828fa4960140870 -> Timestamp: 2024-05-31 09:41:51.374432029 +0000 UTC -> Value: 1 ``` Given that I needed to do the validation of the traceID/spanID on the metrics config as well, I refactored the current validation done in the logging part of the command so that it's now part of the common package. Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> --------- Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for passing a traceID and spanID to be used as exemplars on the generated data points. This was verified with an e2e test using OTel Collector and the debug exporter in detailed verbosity, resulting in this:
Given that I needed to do the validation of the traceID/spanID on the metrics config as well, I refactored the current validation done in the logging part of the command so that it's now part of the common package.
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de