-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/sqlserver] Enable more perf counter metrics #33420
[receiver/sqlserver] Enable more perf counter metrics #33420
Conversation
# Use this changelog template to create an entry for release notes. | ||
|
||
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
change_type: enhancement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm on the fence as to whether this should be considered an enhancement
or breaking
change. These metrics are all shown as being enabled by default, but the reality is they aren't received unless running on Windows.
This change does increase the number of metrics being received when directly connecting to the SQL server instance in reality, so let me know if we should mark this as breaking
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to call it an enhancement
c25f8e7
to
a35c7a1
Compare
Both CI/CD failures are unrelated to this change. I've added frequencies on relevant issues. |
# Use this changelog template to create an entry for release notes. | ||
|
||
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
change_type: enhancement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to call it an enhancement
…#33420) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> These metrics already exist, and are all enabled by default, but were previously not being recorded when directly connecting to the SQL Server instance. This means these metrics will now be enabled by default across all systems and configurations. Metrics: ``` sqlserver.batch.request.rate sqlserver.batch.sql_compilation.rate sqlserver.batch.sql_recompilation.rate sqlserver.page.buffer_cache.hit_ratio sqlserver.user.connection.count ``` **Testing:** <Describe what testing was performed and which tests were added.> Updated tests to account for given metrics **Documentation** Updated documentation to show these metrics are now available on more systems than just Windows.
Description:
These metrics already exist, and are all enabled by default, but were previously not being recorded when directly connecting to the SQL Server instance. This means these metrics will now be enabled by default across all systems and configurations.
Metrics:
Testing:
Updated tests to account for given metrics
Documentation
Updated documentation to show these metrics are now available on more systems than just Windows.