Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/solacereceiver]: Updates to Solace Receiver to use latest semantic conventions - v1.25.0 #33499

Merged
merged 8 commits into from
Jun 19, 2024
Merged

[receiver/solacereceiver]: Updates to Solace Receiver to use latest semantic conventions - v1.25.0 #33499

merged 8 commits into from
Jun 19, 2024

Conversation

oodigie
Copy link
Contributor

@oodigie oodigie commented Jun 11, 2024

Description: Updated the relevant attribute keys to match the latest semantic conventions (v1.25.0).

Link to tracking Issue: N/A

Testing: Updated unit tests to accommodate renamed attribute keys

Documentation: N/A

@oodigie oodigie requested review from djaglowski and a team as code owners June 11, 2024 19:20
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jun 11, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot requested a review from mcardy June 11, 2024 19:20
codeboten
codeboten reviewed Jun 14, 2024
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @oodigie, please sign the CLA

@mcardy please review as code owner

@oodigie
Copy link
Contributor Author

oodigie commented Jun 18, 2024

Thanks for the review @mcardy.
@codeboten, I have signed the CLA but waiting on our internal CLA Manager to approve. They are having some issues with the dashboard and not seeing my signed request(s) so I have opened a Jira bug for this. Hopefully, this will be resolved and we will have the signed CLA approved soon.

@codeboten
Copy link
Contributor

/easycla

@codeboten
Copy link
Contributor

Thanks for the update @oodigie, sometimes /easycla helps, didn't see to in this case.

@oodigie
Copy link
Contributor Author

oodigie commented Jun 18, 2024

@codeboten, the signed CLA has been approved.

@codeboten codeboten merged commit 3bd16df into open-telemetry:main Jun 19, 2024
154 checks passed
@github-actions github-actions bot added this to the next release milestone Jun 19, 2024
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Jul 11, 2024
@oodigie @cparkins
[receiver/solacereceiver]: Updates to Solace Receiver to use latest s…
1c535cc 
…emantic conventions - v1.25.0 (open-telemetry#33499)

**Description:** Updated the relevant attribute keys to match the latest
semantic conventions (v1.25.0).

**Testing:** Updated unit tests to accommodate renamed attribute keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@mcardy mcardy mcardy approved these changes

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

Assignees

@atoulme atoulme

Labels
receiver/solace
Projects
None yet
Milestone
v0.103.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oodigie @codeboten @mcardy @atoulme