Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/elasticsearch] Encode metrics resource attributes in ECS mapping mode #33823

Merged
merged 2 commits into from
Jul 1, 2024
Merged

[exporter/elasticsearch] Encode metrics resource attributes in ECS mapping mode #33823

merged 2 commits into from
Jul 1, 2024

Conversation

carsonip
Copy link
Contributor

@carsonip carsonip commented Jul 1, 2024

Description:

Encode metrics resource attributes in ECS mapping mode

Link to tracking Issue:

Testing:

Unit tests

Documentation:

@carsonip carsonip marked this pull request as ready for review July 1, 2024 11:38
@carsonip carsonip requested a review from a team as a code owner July 1, 2024 11:38
@carsonip carsonip requested a review from jpkrohling July 1, 2024 11:38
ChrsMark
ChrsMark approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since ECS mode is applied to Logs already it makes sense to have it for Metrics well. Thank's!

@andrzej-stencel andrzej-stencel merged commit 74244e4 into open-telemetry:main Jul 1, 2024
156 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 1, 2024
@michalpristas michalpristas mentioned this pull request Jul 1, 2024
Merged
@mergify mergify bot mentioned this pull request Jul 1, 2024
Merged
lalith47 pushed a commit to lalith47/opentelemetry-collector-contrib that referenced this pull request Jul 1, 2024
@carsonip @lalith47
[exporter/elasticsearch] Encode metrics resource attributes in ECS ma…
d672c14 
…pping mode (open-telemetry#33823)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
Encode metrics resource attributes in ECS mapping mode

**Link to tracking Issue:** <Issue number if applicable>

**Testing:** <Describe what testing was performed and which tests were
added.>

Unit tests

**Documentation:** <Describe the documentation added.>
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Jul 11, 2024
@carsonip @cparkins
[exporter/elasticsearch] Encode metrics resource attributes in ECS ma…
1a37295 
…pping mode (open-telemetry#33823)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
Encode metrics resource attributes in ECS mapping mode

**Link to tracking Issue:** <Issue number if applicable>

**Testing:** <Describe what testing was performed and which tests were
added.>

Unit tests

**Documentation:** <Describe the documentation added.>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

@andrzej-stencel andrzej-stencel andrzej-stencel approved these changes

@JaredTan95 JaredTan95 Awaiting requested review from JaredTan95

@ycombinator ycombinator Awaiting requested review from ycombinator

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

Assignees

@songy23 songy23

Labels
exporter/elasticsearch
Projects
None yet
Milestone
v0.104.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@carsonip @ChrsMark @andrzej-stencel @songy23