Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[configgrpc] endpoint validation causes failures in dns resolution #10449

Closed
codeboten opened this issue Jun 20, 2024 · 1 comment · Fixed by #10450
Closed

[configgrpc] endpoint validation causes failures in dns resolution #10449

codeboten opened this issue Jun 20, 2024 · 1 comment · Fixed by #10450
Assignees
@codeboten
Labels
area:config

Comments

@codeboten
Copy link
Contributor

The validation that was added for dns:/// makes it impossible for end users to use dns resolution as documented here: https://github.com/grpc/grpc/blob/master/doc/naming.md#detailed-design

The documentation for NewClient suggests that dns:/// is correct, but that causes the authority to be empty, making it impossible for anyone using a custom authority to configure a custom authority
@codeboten codeboten self-assigned this Jun 20, 2024
@oosariemen
Copy link

Thanks for addressing this issue. It would be preferrable to be able to use a custom authority.

codeboten added a commit to codeboten/opentelemetry-collector that referenced this issue Jun 20, 2024
@codeboten
[configgrpc] support validation for dns:// and dns:///
7fded3a 
This allows users to continue using the recommended dns://authority/host:port notation
when needing to specify a custom authority.

Fixes open-telemetry#10449

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten mentioned this issue Jun 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codeboten codeboten

Labels
area:config
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[otlpexporter] support validation for dns:// and dns:/// codeboten/opentelemetry-collector
3 participants
@codeboten @TylerHelmuth @oosariemen