Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension/zpages] zpages extension should use confighttp.HTTPServerSettings #9368

Closed
atoulme opened this issue Jan 24, 2024 · 3 comments · Fixed by #10276
Closed

[extension/zpages] zpages extension should use confighttp.HTTPServerSettings #9368

atoulme opened this issue Jan 24, 2024 · 3 comments · Fixed by #10276
Assignees
Labels
enhancement New feature or request extension/zpages zPages extension good first issue Good for newcomers

Comments

@atoulme
Copy link
Contributor

atoulme commented Jan 24, 2024

Is your feature request related to a problem? Please describe.
The zpages extension declares a http.Server without much option besides setting its endpoint.

Describe the solution you'd like
It would be good to instead use confighttp.HTTPServerSettings to set up the extension server.

@andrzej-stencel andrzej-stencel added enhancement New feature or request good first issue Good for newcomers labels Jan 24, 2024
@TylerHelmuth TylerHelmuth added the extension/zpages zPages extension label Jan 24, 2024
@Sanket-0510
Copy link
Contributor

I would like to take on this issue, from my understanding of the issue, we need to use httpSettingServer from confighttp go module to setup the extension server.

  1. Will need to import the required go packages from go.opentelemetry.io/collector/config/confighttp,
  2. Implement extension server using confighttp instance
  3. use ToServer method provided by confighttp to configure the server.

I think I can address this issue. I'll open PR for this and will try to fix this.

@atoulme
Copy link
Contributor Author

atoulme commented Jan 24, 2024

I think that’s the right plan. Holler for help if needed!

@Sanket-0510
Copy link
Contributor

@atoulme I have opened a draft pull request, I don't know why but was failing onto some checks, but the server implementation looks good to me but still facing some issues, better if you can provide some feedback.

regards,
Sanket

codeboten pushed a commit that referenced this issue Jun 12, 2024
)

#### Description
use confighttp.ServerConfig as part of the configuration of the
zpagesextension

#### Link to tracking issue
Fixes #9368
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request extension/zpages zPages extension good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants