[builder] remove ambigious import codepath #10015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code was added to handled an ambiguous import caused by a dependency that has been updated since v0.98.0. Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10015 +/- ##
==========================================
+ Coverage 91.54% 91.55% +0.01%
==========================================
Files 360 360
Lines 16695 16693 -2
==========================================
Hits 15284 15284
+ Misses 1074 1073 -1
+ Partials 337 336 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
mx-psi
reviewed
Apr 23, 2024
| @@ -137,7 +137,7 @@ func TestVersioning(t *testing.T) { | |||
| cfg.Distribution.Go = "go" | |||
| cfg.Exporters = []Module{ | |||
| { | |||
| GoMod: "go.opentelemetry.io/collector/exporter/otlpexporter v0.96.0", | |||
| GoMod: "go.opentelemetry.io/collector/exporter/otlpexporter v0.97.0", | |||
There was a problem hiding this comment.
previous versions relied on the ambiguous import
There was a problem hiding this comment.
So... previous versions now fail to build? Sorry, I don't get it
There was a problem hiding this comment.
Sorry I wasn't really clear. Yes previous versions of the components (ones that import the problematic dependency) continue to raise an ambiguous import error unless they're updated.
mx-psi
approved these changes
Apr 24, 2024
andrzej-stencel
pushed a commit
to andrzej-stencel/opentelemetry-collector
that referenced
this pull request
May 27, 2024
This code was added to handled an ambiguous import caused by a dependency that has been updated since v0.98.0. --------- Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was added to handled an ambiguous import caused by a dependency that has been updated since v0.98.0.