Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate profiling pdata #10195

Merged
merged 9 commits into from
May 24, 2024
Merged

Generate profiling pdata #10195

merged 9 commits into from
May 24, 2024

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented May 21, 2024

Description

This generates the pdata for profiles.

Link to tracking issue

Last step of #10109.

Testing

The generated code is unit-tested by generated tests.

cc @mx-psi

@dmathieu dmathieu marked this pull request as ready for review May 21, 2024 16:25
@dmathieu dmathieu requested a review from a team as a code owner May 21, 2024 16:25
@dmathieu dmathieu requested a review from atoulme May 21, 2024 16:25
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.52%. Comparing base (38e1bad) to head (36632e2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10195      +/-   ##
==========================================
+ Coverage   91.99%   92.52%   +0.53%     
==========================================
  Files         361      387      +26     
  Lines       16982    18191    +1209     
==========================================
+ Hits        15622    16831    +1209     
  Misses       1020     1020              
  Partials      340      340              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@songy23 songy23 requested a review from mx-psi May 21, 2024 21:34
versions.yaml Outdated Show resolved Hide resolved
pdata/pprofile/go.mod Outdated Show resolved Hide resolved
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This has to wait until contrib-tests work again (should happen soon)

@mx-psi
Copy link
Member

mx-psi commented May 23, 2024

cc @open-telemetry/collector-approvers last call to review this one

@mx-psi mx-psi merged commit 5ba6000 into open-telemetry:main May 24, 2024
49 checks passed
@github-actions github-actions bot added this to the next release milestone May 24, 2024
@dmathieu dmathieu deleted the pdata-profiles branch May 24, 2024 16:11
andrzej-stencel pushed a commit to andrzej-stencel/opentelemetry-collector that referenced this pull request May 27, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This generates the pdata for profiles.

<!-- Issue number if applicable -->
#### Link to tracking issue
Last step of open-telemetry#10109.

<!--Describe what testing was performed and which tests were added.-->
#### Testing

The generated code is unit-tested by generated tests.

cc @mx-psi

---------

Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Co-authored-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
steves-canva pushed a commit to Canva/opentelemetry-collector that referenced this pull request Jun 14, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This generates the pdata for profiles.

<!-- Issue number if applicable -->
#### Link to tracking issue
Last step of open-telemetry#10109.

<!--Describe what testing was performed and which tests were added.-->
#### Testing

The generated code is unit-tested by generated tests.

cc @mx-psi

---------

Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Co-authored-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants