Update validate command to use the new configuration options #10203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
update-validate-command
branch
2 times, most recently
from
ecf3fa9
to
8040ecb
Compare
dmitryax
force-pushed
the
update-validate-command
branch
from
8040ecb
to
0f2029c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10203 +/- ##
==========================================
+ Coverage 91.90% 91.91% +0.01%
==========================================
Files 361 361
Lines 16970 16964 -6
==========================================
- Hits 15596 15593 -3
+ Misses 1032 1029 -3
Partials 342 342 ☔ View full report in Codecov by Sentry. |
samiura
approved these changes
May 21, 2024
bogdandrutu
approved these changes
May 22, 2024
songy23
approved these changes
May 22, 2024
evan-bradley
approved these changes
May 22, 2024
songy23
added
the
ready-to-merge
andrzej-stencel
pushed a commit
to andrzej-stencel/opentelemetry-collector
that referenced
this pull request
May 27, 2024
…lemetry#10203) After open-telemetry#9516, the `validate` sum-command works differently from the root command. If a downstream distribution provides `URIs` as part of the new `ConfigProviderSettings` without `--config` flag, the `validate` command fails with ``` 2024/05/21 15:53:25 main.go:85: application run finished with error: at least one config flag must be provided ```
steves-canva
pushed a commit
to Canva/opentelemetry-collector
that referenced
this pull request
Jun 14, 2024
…lemetry#10203) After open-telemetry#9516, the `validate` sum-command works differently from the root command. If a downstream distribution provides `URIs` as part of the new `ConfigProviderSettings` without `--config` flag, the `validate` command fails with ``` 2024/05/21 15:53:25 main.go:85: application run finished with error: at least one config flag must be provided ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #9516, the
validatesum-command works differently from the root command.If a downstream distribution provides
URIsas part of the newConfigProviderSettingswithout--configflag, thevalidatecommand fails with