Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mdatagen: support setting telemetry level in telemetry builder #10234

Merged

Conversation

codeboten
Copy link
Contributor

This allows components to set the minimum level needed for them to produce telemetry. By default, this is set to configtelemetryLevelBasic. If the telemetry level is below that minimum level, then the noop meter is used for metrics.

This allows components to set the minimum level needed for them to produce telemetry. By default, this is set to configtelemetryLevelBasic. If the telemetry level is below that minimum level, then the noop meter is used for metrics.

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten requested a review from a team as a code owner May 27, 2024 19:33
@codeboten codeboten requested a review from songy23 May 27, 2024 19:33
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 65.75342% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 92.47%. Comparing base (c7c3401) to head (439fd20).

Files Patch % Lines
...ereceiver/internal/metadata/generated_telemetry.go 58.33% 4 Missing and 1 partial ⚠️
...terhelper/internal/metadata/generated_telemetry.go 58.33% 4 Missing and 1 partial ⚠️
...sorhelper/internal/metadata/generated_telemetry.go 58.33% 4 Missing and 1 partial ⚠️
...verhelper/internal/metadata/generated_telemetry.go 58.33% 4 Missing and 1 partial ⚠️
...perhelper/internal/metadata/generated_telemetry.go 58.33% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10234      +/-   ##
==========================================
- Coverage   92.59%   92.47%   -0.12%     
==========================================
  Files         387      387              
  Lines       18198    18252      +54     
==========================================
+ Hits        16850    16879      +29     
- Misses       1007     1027      +20     
- Partials      341      346       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeboten codeboten merged commit 52a9520 into open-telemetry:main May 28, 2024
47 of 48 checks passed
@codeboten codeboten deleted the codeboten/mdatagen-telemetrylevel branch May 28, 2024 15:59
@github-actions github-actions bot added this to the next release milestone May 28, 2024
steves-canva pushed a commit to Canva/opentelemetry-collector that referenced this pull request Jun 14, 2024
…telemetry#10234)

This allows components to set the minimum level needed for them to
produce telemetry. By default, this is set to
`configtelemetryLevelBasic`. If the telemetry level is below that
minimum level, then the noop meter is used for metrics.

---------

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants