[configgrpc] Revert to third-party compressor for zstd #10394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkrohling
force-pushed
the
jpkrohling/switch-back-to-go-grpc-compression-for-zstd
branch
from
38c69d1
to
d77f4a6
Compare
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
jpkrohling
force-pushed
the
jpkrohling/switch-back-to-go-grpc-compression-for-zstd
branch
from
d77f4a6
to
2d88482
Compare
TylerHelmuth
approved these changes
Jun 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10394 +/- ##
==========================================
+ Coverage 92.53% 92.55% +0.01%
==========================================
Files 388 387 -1
Lines 18317 18284 -33
==========================================
- Hits 16949 16922 -27
+ Misses 1022 1017 -5
+ Partials 346 345 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
codeboten
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We switched back to our compression logic for zstd when a CVE was found on the third-party library we were using. Now that the third-party library has been fixed, we can revert to that one. For end-users, this has no practical effect. The reproducers for the CVE were tested against this patch, confirming we are not reintroducing the bugs.
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de