Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pprofile wrapper and testdata #10401

Merged
merged 12 commits into from
Jun 24, 2024
Merged

Conversation

dmathieu
Copy link
Member

Description

This adds pprofile wrapper (the non-generated bit of pprofile), as well as test data.

cc @mx-psi

@dmathieu dmathieu marked this pull request as ready for review June 13, 2024 12:32
@dmathieu dmathieu requested a review from a team as a code owner June 13, 2024 12:32
@dmathieu

This comment was marked as resolved.

@dmathieu dmathieu force-pushed the pprofile-wrapper branch 14 times, most recently from 5c00039 to 7396769 Compare June 17, 2024 10:05
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 45.45455% with 18 lines in your changes missing coverage. Please review.

Project coverage is 92.38%. Comparing base (3364ba1) to head (d822590).

Files Patch % Lines
pdata/internal/wrapper_profiles.go 0.00% 16 Missing ⚠️
pdata/pprofile/profiles.go 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10401      +/-   ##
==========================================
- Coverage   92.46%   92.38%   -0.09%     
==========================================
  Files         390      392       +2     
  Lines       18461    18494      +33     
==========================================
+ Hits        17070    17085      +15     
- Misses       1036     1054      +18     
  Partials      355      355              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmathieu dmathieu force-pushed the pprofile-wrapper branch 2 times, most recently from 0ea9784 to 150f9c1 Compare June 17, 2024 10:17
@dmathieu

This comment was marked as resolved.

cmd/builder/internal/builder/main_test.go Show resolved Hide resolved
pdata/testdata/profile.go Outdated Show resolved Hide resolved
@dmathieu dmathieu force-pushed the pprofile-wrapper branch 2 times, most recently from faa4c92 to 892d8f3 Compare June 20, 2024 12:46
pdata/testdata/go.mod Outdated Show resolved Hide resolved
dmathieu and others added 3 commits June 24, 2024 13:48
@mx-psi mx-psi added Skip Changelog PRs that do not require a CHANGELOG.md entry and removed Skip Changelog PRs that do not require a CHANGELOG.md entry labels Jun 24, 2024
@mx-psi mx-psi merged commit 227fb82 into open-telemetry:main Jun 24, 2024
69 of 86 checks passed
@github-actions github-actions bot added this to the next release milestone Jun 24, 2024
@dmathieu dmathieu deleted the pprofile-wrapper branch June 24, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants