Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cartservice] Update to .NET8 #1272

Merged
merged 3 commits into from
Dec 9, 2023

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Nov 24, 2023

Changes

Update cartservice to .NET8 which is new LTS release.

Replaces #1269
Fixes #1262

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • [ ] Appropriate documentation updates in the docs N/A
  • [ ] Appropriate Helm chart updates in the helm-charts N/A

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@Kielek Kielek force-pushed the cartservice-net8 branch 14 times, most recently from 983b38e to 253b053 Compare November 27, 2023 12:57
@Kielek
Copy link
Contributor Author

Kielek commented Nov 29, 2023

@austinlparker, there is a problem while restoring package. (probably the same as on main). Still do not know how to proceed.

@austinlparker
Copy link
Member

hmm. https://devblogs.microsoft.com/dotnet/improving-multiplatform-container-support/

seems like building on qemu isn't really supported...? i wonder if the stuff in this could help

@Kielek Kielek force-pushed the cartservice-net8 branch 3 times, most recently from fc71e07 to 94050b6 Compare December 8, 2023 11:41
@Kielek Kielek marked this pull request as ready for review December 8, 2023 11:41
@Kielek Kielek requested a review from a team as a code owner December 8, 2023 11:41
@Kielek
Copy link
Contributor Author

Kielek commented Dec 8, 2023

@austinlparker, great findings!
I have adjusted Dockerfile and build process.
Differences - to build step we are using non-alpine - by default alpine is not working with grpc tools package.
The final base image is the same as before - alpine.

I do not have the arm64 env. to verify if the build will be working fine. Build logs looks promising. Austin, could you please check the results?

@richlander, is there any chance that you review changes in docker build process?

Copy link
Member

@mviitane mviitane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs fine. Verified with arm64 (apple).

@austinlparker
Copy link
Member

Also tested locally and it seems to be working. Fingers crossed!

@austinlparker austinlparker merged commit b61a935 into open-telemetry:main Dec 9, 2023
27 checks passed
@Kielek Kielek deleted the cartservice-net8 branch December 10, 2023 15:35
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* [cartservice] Update to .NET8

* Do not install QEMU for .NET

* Use BUILDPLATFORM/TARGETARCH
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cartservice package restore errors
3 participants