Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update shippingservice #1287

Merged
merged 7 commits into from
Dec 7, 2023

Conversation

TommyCpp
Copy link
Contributor

@TommyCpp TommyCpp commented Dec 4, 2023

Changes

Fix issues in #1255

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@TommyCpp TommyCpp marked this pull request as ready for review December 5, 2023 01:25
@TommyCpp TommyCpp requested a review from a team as a code owner December 5, 2023 01:25
@puckpuck
Copy link
Contributor

puckpuck commented Dec 5, 2023

@TommyCpp, thanks for this. Can you add a changelog entry to indicate upgrading the otel libraries for the shipping service?

Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julianocosta89
Copy link
Member

@TommyCpp I've added the changelog in order to get this one merged, hope you don't mind. 😅

@julianocosta89 julianocosta89 merged commit 4224643 into open-telemetry:main Dec 7, 2023
27 checks passed
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* chore(deps): update shippingservice

* chore: update dependencies to v0.21

* changelog

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Austin Parker <austin@ap2.io>
Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants