Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent baggage propagation #1545

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

beeme1mr
Copy link
Contributor

Changes

Automatically adds session information to baggage for all requests from the browser and synthetic tests. This information is then used in downstream services as part of the feature flag evaluation context. The AdService has also been updated to leverage this change.

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@beeme1mr beeme1mr requested a review from a team as a code owner April 23, 2024 13:57
@github-actions github-actions bot added docs-update-required Requires documentation update helm-update-required Requires an update to the Helm chart when released labels Apr 23, 2024
src/loadgenerator/locustfile.py Show resolved Hide resolved
src/loadgenerator/locustfile.py Show resolved Hide resolved
src/loadgenerator/locustfile.py Show resolved Hide resolved
src/flagd/demo.flagd.json Show resolved Hide resolved
@beeme1mr
Copy link
Contributor Author

Hey @austinlparker, would you have a moment to review this PR? It includes some changes that you had as TODO comments. Thanks!

@austinlparker austinlparker merged commit 61d6a5f into open-telemetry:main Apr 30, 2024
27 checks passed
@beeme1mr beeme1mr deleted the improve-baggage-handling branch April 30, 2024 18:05
maxhakansson added a commit to maxhakansson/opentelemetry-demo that referenced this pull request May 10, 2024
* main: (138 commits)
  docs: update sig meeting schedule (open-telemetry#1567)
  chore(deps): upgrade otel collector contrib and opensearch (open-telemetry#1566)
  fix(loadgenerator): use add_hooks openfeature method (open-telemetry#1565)
  Revert "remove axoflow link (open-telemetry#1457)" (open-telemetry#1563)
  feat: configure feature flag tracing for Python services (open-telemetry#1553)
  chore(deps): upgrade go dependencies to latest versions (open-telemetry#1561)
  remove deprecated version property (open-telemetry#1557)
  chore(deps): upgrade otel collector contrib, grafana and prometheus (open-telemetry#1559)
  add imageprovider (open-telemetry#1552)
  [flagd] - upgrade to latest version and memory limits (open-telemetry#1554)
  update kubernetes manifest to 1.9.0 (open-telemetry#1555)
  [chore] specify default value for tracetest image version (open-telemetry#1551)
  improve baggage propagation (open-telemetry#1545)
  Bump gradle/wrapper-validation-action from 3.3.1 to 3.3.2 (open-telemetry#1548)
  [kafka][checkoutservice][frauddetectionservice] add kafkaQueueProblems featureflag (open-telemetry#1528)
  fix(productcatalogservice): handle err returned from openfeature.SetProvider func (open-telemetry#1535)
  feat(otelcol): add redisreceiver (open-telemetry#1537)
  chore(deps): upgrade opentelemetry-java-instrumentation for kafka to 2.3.0 (open-telemetry#1533)
  Bump gradle/wrapper-validation-action from 3.3.0 to 3.3.1 (open-telemetry#1539)
  chore(deps): upgrade opentelemetry-java-instrumentation to 2.3.0 (open-telemetry#1532)
  ...

# Conflicts:
#	docker-compose.minimal.yml
#	src/frontend/package-lock.json
AlexPSplunk pushed a commit to splunk/edu-opentelemetry-demo that referenced this pull request Jul 10, 2024
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Co-authored-by: Austin Parker <austin@ap2.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-update-required Requires documentation update helm-update-required Requires an update to the Helm chart when released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants