featureflagservice: add healthcheck to postgres dependency #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puckpuck
approved these changes
Aug 17, 2022
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue where the FeatureFlagService migrations fail because postgres isn't actually "ready" it is only "started".
Instead of depending only on the postgres container being started it now depends on it being healthy too.
A problem is that
condition: service_healthyis not in the compose v3 docs (only v2). But it does seem that it might be working.If it doesn't work in v3 I'd argue we should switch to v2. Unless there are features from v3 being used (I don't see any) then use of v2 (specifically
version: '2.4') makes sense. My understanding is that v3 isn't really an update to compose v2 but that they can be thought of as separate, where v3 is meant for Swarm use.