Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add traffic to adservice & recommendataion service #379

Merged

Conversation

dineshg13
Copy link
Member

Fixes #360

Changes

Please provide a brief description of the changes here.

  1. Add .venv to gitignore
  2. Format locustfile.py using black formatter
  3. Add additional routes in loadgenerator to hit frontend ads & recommendation endpoints
  4. Add PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python to ensure recommendation-service comes up.

Earlier PR was reverted #375 because of issue. That has been addressed here.

@dineshg13 dineshg13 requested a review from a team as a code owner September 19, 2022 19:42
@cartersocha
Copy link
Contributor

@dineshg13, can you glance at this issue too while you're at it? #381

@dineshg13
Copy link
Member Author

@cartersocha This PR address #381 . I have added PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION to docker compose for recommendation service

Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cartersocha cartersocha merged commit dbef439 into open-telemetry:main Sep 20, 2022
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Demo] Adservice & Recommendation Service not getting any traffic
3 participants